Set assembly version used for conversion in OpenApiInfo object #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millicentachieng
force-pushed
the
task/ma/set-assembly-version
branch
from
b6245d0 to
70728e1
Compare
millicentachieng
requested review from
baywet,
darrelmiller,
irvinesunday,
peombwa,
xuzhg and
zengin
as code owners
irvinesunday
reviewed
Oct 3, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiInfoGenerator.cs
Outdated
Show resolved
Hide resolved
irvinesunday
reviewed
Oct 3, 2022
src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj
Show resolved
Hide resolved
baywet
requested changes
Oct 3, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiInfoGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj
Show resolved
Hide resolved
baywet
previously approved these changes
Oct 3, 2022
baywet
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
This PR
ShowAssemblyInfo. This is added to be set to false for tests to avoid updating tests each time the assembly version changes