Skip to content

Fixes missing bound operations on some navigation property paths #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2022
Merged

Fixes missing bound operations on some navigation property paths #227

merged 2 commits into from
May 30, 2022

Conversation

@irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented May 30, 2022

Fixes #201

This PR:

  • Removes the conditional expressions that prevent generation of bound operations for a given set of paths when the conditional expression that comes before this is true. This also necessitated refactoring of the target private method signatures and local variables.
  • Updates the integration test results as a product of the above fix.
  • With the above fix, the path /users/{user-id}/followedSites/microsoft.graph.add can now be generated:

image

@irvinesunday irvinesunday requested a review from xuzhg as a code owner May 30, 2022 17:33
@irvinesunday irvinesunday self-assigned this May 30, 2022
@irvinesunday irvinesunday merged commit 33efcb0 into master May 30, 2022
@irvinesunday irvinesunday deleted the is/fix-missing-bound-operations branch May 30, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@peombwa peombwa Awaiting requested review from peombwa

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@irvinesunday irvinesunday

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing add action of "followed sites" in the OpenAPI document

3 participants

@irvinesunday @baywet