fixes a bug where switch to semver versions would make comparison script fail #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
darrelmiller,
irvinesunday and
xuzhg
as code owners
danielmbaluka
approved these changes
Mar 3, 2022
Contributor
danielmbaluka
left a comment
danielmbaluka
left a comment
There was a problem hiding this comment.
Looks good @baywet . FYI I had to install version 1 of SemVerPS in order to test the script locally. See https://github.com/Sarafian/SemVerPS/#core-editions-only
Member
Author
|
thanks for the insight, that's probably because you're running on powershell classic (as opposed to PS core). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once we deployed preview1 to nuget, this switched the package to semver mode, and to a different API endpoint.
This PR fixes the version comparison script.