Skip to content

- fixes a bug where custom error types would trim other types from the description #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2022
Merged

- fixes a bug where custom error types would trim other types from the description #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a57ba2
- fixes a bug where custom error types would trim other types from th…
baywet Mar 2, 2022
bbc495b
- bumps version number in the csproj to release bugfix
baywet Mar 3, 2022
cc4749d
- fixes pr number
baywet Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,14 @@ public static IDictionary<string, OpenApiSchema> CreateSchemas(this ODataContext
case EdmSchemaElementKind.TypeDefinition: // Type definition
{
IEdmType reference = (IEdmType)element;
var fullTypeName = reference.FullTypeName();
if(reference is IEdmComplexType &&
reference.FullTypeName().EndsWith(context.Settings.InnerErrorComplexTypeName, StringComparison.Ordinal))
fullTypeName.Split(new char[] {'.'}, StringSplitOptions.RemoveEmptyEntries)
.Last()
.Equals(context.Settings.InnerErrorComplexTypeName, StringComparison.Ordinal))
continue;

schemas.Add(reference.FullTypeName(), context.CreateSchemaTypeSchema(reference));
schemas.Add(fullTypeName, context.CreateSchemaTypeSchema(reference));
}
break;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageId>Microsoft.OpenApi.OData</PackageId>
<SignAssembly>true</SignAssembly>
<Version>1.0.10-preview1</Version>
<Version>1.0.10-preview2</Version>
<Description>This package contains the codes you need to convert OData CSDL to Open API Document of Model.</Description>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageTags>Microsoft OpenApi OData EDM</PackageTags>
<RepositoryUrl>https://github.com/Microsoft/OpenAPI.NET.OData</RepositoryUrl>
<PackageReleaseNotes>
- Adds path items for properties of complex type. #176, #15
- Describes errors on error response codes instead of default. #172, #165
- Describes errors on error response codes instead of default. #172, #165, #193
- Fixes a bug where reference objects are not created correctly. #171
- Adds support for enum values descriptions. #164
- Declares path parameters on path item instead of operation. #159
Expand Down