adds support for properties of complex type and navigation properties on complex types #158
Conversation
…property Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
… paths Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
… request body Signed-off-by: Vincent Biret <[email protected]>
… types Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
requested review from
darrelmiller,
irvinesunday and
xuzhg
as code owners
| .Where(CanFilter)) | ||
| { | ||
| var count = _model.GetRecord<CountRestrictionsType>(np, CapabilitiesConstants.CountRestrictions); | ||
| RetrieveNavigationPropertyPaths(np, count, currentPath, convertSettings); |
There was a problem hiding this comment.
RetrieveNavigationPropertyPaths will throw an exception when calling ShouldExpandNavigationProperty since OdataSegment.EntityType is not yet implemented:
There was a problem hiding this comment.
thanks for reporting that, can you give it another try with this latest commit please?
There was a problem hiding this comment.
Not sure if it's related but, a null exception is thrown when attempting to retrieve the "Entity type of a Complex type property segment" here:
Example:
The complex property segment in question:
The complex type which has containment navigation properties
There was a problem hiding this comment.
I've just pushed another commit that should solve your issue, please pull and give it another try.
…e descriptions Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
force-pushed
the
feature/nav-prop-complex-type
branch
from
5e5c41e to
104b4cb
Compare
| OpenApiSchema schema = new OpenApiSchema | ||
| { | ||
| OpenApiSchema schema = new() | ||
| { |
There was a problem hiding this comment.
are you referring to the new() syntax?
|
Basically, it looks good to me. |
test/Microsoft.OpenAPI.OData.Reader.Tests/PathItem/ComplexPropertyPathItemHandlerTests.cs
Show resolved
Hide resolved
|
@baywet We cannot generate paths for properties that are complex types unless there is a specific annotation to indicate that the path is supported. It causes way too many paths to be generated. |
|
@darrelmiller this PR resulted in a 3x path items increase. (considering it might be impacted by inaccurate contains target attributes as well) I'd be ok with having a default of "if there's no annotation saying it's supported, don't add anything" and this should be a quick change once we know which annotation to read in. Which annotation should I read to implement that change? |
fixes #15
This pull request adds path items for complex properties on entities as well as path items for navigation properties in complex types. Subsequently, it adds raw count, type cast and $ref path segments under those when required.
For a detail of which paths we're adding, see #15