Skip to content

[Fix] Add support for other Org.OData.Core.V1.RevisionKind enum values #372

@irvinesunday

Description

@irvinesunday

OData has 3 supported Revision Kinds:

  • Added
  • Modified
  • Deprecated

Currently, version 1.4.0-preview2 only supports the annotation Org.OData.Core.V1.RevisionKind/Deprecated.

A CSDL with the below annotation which includes the Added RevisionKind annotation currently throws a System.InvalidOperationException exception: "The kind of the revision must be Deprecated."

<Annotations Target="microsoft.graph.endWorkingTime(microsoft.graph.workingTimeSchedule)">
  <Annotation Term="Org.OData.Core.V1.Description" String="Triggers the policies associated with the end of working hours." ags:OwnerService="Microsoft.Teams.WorkingTime" />
  <Annotation Term="Org.OData.Core.V1.Revisions" ags:OwnerService="Microsoft.Teams.WorkingTime">
    <Collection>
      <Record>
        <PropertyValue Property="Date" Date="2023-04-05" />
        <PropertyValue Property="Kind">
          <EnumMember>Org.OData.Core.V1.RevisionKind/Added</EnumMember>
        </PropertyValue>
        <PropertyValue Property="RemovalDate" Date="2023-10-04" />
        <PropertyValue Property="Version" String="2023-04/PrivatePreview:TeamsWorkingTime" />
      </Record>
    </Collection>
  </Annotation>
</Annotations>

We need to modify the lib. to support the other revision kinds.

Metadata

Metadata

Assignees

Labels

priority:p0Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions