Handle additional edge cases for MRTK inspectors #4661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luis-valverde-ms and @provencher FYI |
david-c-kline
suggested changes
May 31, 2019
Assets/MixedRealityToolkit.SDK/Inspectors/Input/Handlers/BaseInputHandlerInspector.cs
Show resolved
Hide resolved
Assets/MixedRealityToolkit.SDK/Inspectors/Input/Handlers/PointerClickHandlerInspector.cs
Show resolved
Hide resolved
|
After syncing with @davidkline-ms , the use of MRTK object references are going to remain in the PR. This is because
|
|
/azp run mrtk_PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
david-c-kline
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Thanks for taking the time to discuss this change @Troy-Ferrell!
wiwei
approved these changes
Jun 5, 2019
|
Thanks! |
This was referenced Jun 5, 2019
This was referenced Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There are two key dependencies between profiles/inputhandlers: input actions and speech keywords (i.e speechinputhandler). The inspector logic for these impacted components has been updated to be simpler, more consistent, and accurate with useful error messages to the user informing them of the issue (i.e no MRTK in scene, etc etc.).
Rendering of speech commands when rendered as sub-profile view (i.e within input profile) would not work properly for layout. Switched model to be vertical components to preserve useful formatting
Added forced height on scrollview for input actions inspector when rendered as sub-profile
Fixed edge case where inspector logic does not account for an active profile assigned to the scene MRTK instance (an unlikely edge case)
Fixed DefaultMouseProfile to correctly set IsCustomProfile to false
Fixed DefaultHololens2..profiles to correctly set IsCustomProfile to false
Fixed "Back to.." buttons for profile up the hierarchy to actually render
Changes
Harden MRTK inspectors & increase re-usability of code #4467
Harden MRTK inspectors & increase re-usability of code
Can't bind the keyboard input for voice input #4654
Can't bind the keyboard input for voice input
Verification
Removed input actions profile
Removed active profile
Removed MRTK instance
Switched hierarchy with multiple gesture profiles (but only one active in instance)
Deleted MRTK instance & re-added with SpeechInputHandler button when error message shows