Diagnostics Visual Profiler Improvements #4388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
approved these changes
May 17, 2019
…RealityToolkit-Unity into mrtk_development_visual_profiler
Thank you Kurtis! Just fixed the merge. |
|
/azp run mrtk_pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
julenka
approved these changes
May 18, 2019
| /// </summary> | ||
| bool ShowProfiler { get; set; } | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
@wiwei FYI this is a breaking change technically, since anybody implementing the MRDiagnosticsSystem would now need to implement these two properties. I think it's fine, but we should add it to the release notes.
There was a problem hiding this comment.
Nice catch, thank you Julia!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Visual Profiler now supports user defined colors for performance thresholds on the frame info panel. Defaults to green when at 95%+ of the target framerate, yellow when at 75%+ of the target framerate, and red otherwise. (A request from multiple users.)
Portions of the profiler can be dynamically toggled on/off, such as the frame info panel and memory stats.
Verification
Verify the Visual Profiler displays in editor and player .
Fixes: #4414