Remove flux #52
Merged
Remove flux #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Excellent |
Kikobeats
reviewed
Dec 25, 2024
|
@Kikobeats I am sure the following lines cause the error: test/testHelpers/requireSources.js 'navigator' is already defined in 'global' and cannot be modified. Maybe you should remove this line since global.navigator.userAgent already gives something like 'node.js' (not the exact string but similar). However, I cannot guarantee that the removal will resolve the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the flux is deprecated, I removed it from the project and simulated a mini Dispatcher class. @Kikobeats