Skip to content

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 14, 2022

Q A
New Feature yes
RFC yes

Description

Made a start on this, but there is so much mocking, I'm losing the will to live.

If preferred, I can revert the 8.2 support and merge as-is… It's gonna take ages to get rid of prophecy here…

@gsteel gsteel added Enhancement New feature or request Work In Progress labels Oct 14, 2022
@gsteel gsteel added this to the 2.6.0 milestone Oct 14, 2022
@gsteel
Copy link
Member Author

gsteel commented Oct 15, 2022

lcobucci/jwt needed bumping to ^4 for 8.2 lowest to pass, originally a transitive dep of oauth2-server. Should this be moved to a dev-dep instead @Ocramius?

@Ocramius
Copy link
Member

Imo we could add a conflict with earlier versions, rather than introducing a hard dependency here

@gsteel
Copy link
Member Author

gsteel commented Oct 16, 2022

Thanks @Ocramius :)

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge baseline reduction: well done, @gsteel!

@Ocramius Ocramius self-assigned this Oct 16, 2022
@Ocramius Ocramius merged commit 19e8591 into mezzio:2.6.x Oct 16, 2022
@gsteel gsteel deleted the PHP-8.2 branch October 16, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants