FIX: Correctly parse response in Client's ReadResource #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue metoro-io#67 where the Client's ReadResource method was incorrectly attempting to parse server responses. The bug occurred because the response type returned by the server (ResourceResponse) differed from what the client expected (resourceResponseSent).
|
I hit this obstacle while building an LLM tool... |
|
could you merge it? @Chrisbattarbee |
ecekyn
approved these changes
May 22, 2025
|
Yep you are right, thanks for the contribution. Merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #67 where the Client's ReadResource method was incorrectly attempting to parse server responses. The bug occurred because the response type returned by the server (ResourceResponse) differed from what the client expected (resourceResponseSent).