-
Notifications
You must be signed in to change notification settings - Fork 4
Add SO(3)/O(3)-averaging calculator wrappers #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ppegolo
wants to merge
16
commits into
main
Choose a base branch
from
rotational-average
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7ed97e9
Remove net forces in ASE calculator
ppegolo 159b174
Add SO3 and O3 averaging calculators
ppegolo 186810f
Merge branch 'main' into rotational-average
ppegolo 484a4a2
Update
ppegolo 84706dc
Fix typing
ppegolo ea98c0d
Make scipy an optional dependency
ppegolo d375984
Update rotation routines
ppegolo 57c953e
Simplify args
ppegolo b6354b7
Fix bug
ppegolo 6a09b26
Add group symmetrization
ppegolo 704b923
small change
ppegolo 971c22b
clean up and add tests
ppegolo 4319e31
Merge branch 'main' into rotational-average
ppegolo 6eec538
lint
ppegolo a935bf4
add deps for testing
ppegolo bb96a6e
Add mention in the docs
ppegolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,8 @@ Supported model outputs | |
:py:meth:`ase.Atoms.get_forces`, …); | ||
- arbitrary outputs can be computed for any :py:class:`ase.Atoms` using | ||
:py:meth:`MetatomicCalculator.run_model`; | ||
- for non-equivariant architectures like PET, rotatonally-averaged energies, forces, | ||
and stresses can be computed using :py:class:`SymmetrizedCalculator`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should also add a link to this page: https://docs.metatensor.org/metatomic/latest/torch/reference/ase.html |
||
|
||
How to install the code | ||
^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth a link to PET in metatrain, and maybe also link to another non-equivariant architecture?