Merge pull request #29 from metaneutrons/develop #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
metaneutrons
added a commit
that referenced
this pull request
Aug 20, 2025
🐳 CONTAINER BUILD FIXES: Correct Docker Compose context paths and configurations ## Issues Fixed ### 1. 🚨 Docker Compose Context Path Resolution **Problem**: Paths were being doubled up (e.g., ) **Root Cause**: Docker Compose interprets context paths relative to compose file location, not working directory **Solution**: - App container: Use to reach solution root from compose file location - Other containers: Use relative paths like from compose file location - Config volumes: Use relative to compose file location ### 2. 🔧 App Container Dockerfile Optimization **Problem**: Circular reference when copying entire project directory including TestData **Solution**: - Optimized Dockerfile to copy only necessary source files - Added proper health checks and security (non-root user) - Improved build caching with targeted COPY commands ### 3. 📁 Config File Organization **Maintained**: Config files remain in as requested **Verified**: Volume mounts correctly reference config files relative to compose file location ## Technical Details ### Context Path Resolution ### Volume Mounts ## Verification - ✅ All containers build successfully with #1 [internal] load local bake definitions #1 reading from stdin 3.15kB done #1 DONE 0.0s #2 [snapcast-client-kitchen internal] load build definition from Dockerfile #2 transferring dockerfile: 685B done #2 DONE 0.0s #3 [snapcast-server internal] load build definition from Dockerfile #3 transferring dockerfile: 6.14kB done #3 DONE 0.0s #4 [app internal] load build definition from Dockerfile #4 transferring dockerfile: 3.04kB done #4 DONE 0.0s #5 [knxd internal] load build definition from Dockerfile #5 transferring dockerfile: 1.48kB done #5 DONE 0.0s #6 [snapcast-server internal] load metadata for docker.io/library/alpine:3.21 #6 DONE 0.0s #7 [app internal] load metadata for mcr.microsoft.com/dotnet/sdk:9.0 #7 DONE 0.0s #8 [snapcast-client-bedroom internal] load metadata for docker.io/library/alpine:latest #8 DONE 0.0s #9 [knxd internal] load metadata for docker.io/library/alpine:edge #9 DONE 0.0s #10 [app internal] load .dockerignore #10 transferring context: 374B done #10 DONE 0.0s #11 [snapcast-server internal] load .dockerignore #11 transferring context: 2B done #11 DONE 0.0s #12 [snapcast-client-kitchen internal] load .dockerignore #12 transferring context: 2B done #12 DONE 0.0s #13 [knxd internal] load .dockerignore #13 transferring context: 2B done #13 DONE 0.0s #14 [app development 1/4] FROM mcr.microsoft.com/dotnet/sdk:9.0@sha256:840f3b62b9742dde4461a3c31e38ffd34d41d7d33afd39c378cfcfd5dcb82bd5 #14 resolve mcr.microsoft.com/dotnet/sdk:9.0@sha256:840f3b62b9742dde4461a3c31e38ffd34d41d7d33afd39c378cfcfd5dcb82bd5 0.0s done #14 DONE 0.0s #15 [snapcast-server builder 1/5] FROM docker.io/library/alpine:3.21@sha256:b6a6be0ff92ab6db8acd94f5d1b7a6c2f0f5d10ce3c24af348d333ac6da80685 #15 resolve docker.io/library/alpine:3.21@sha256:b6a6be0ff92ab6db8acd94f5d1b7a6c2f0f5d10ce3c24af348d333ac6da80685 0.0s done #15 DONE 0.0s #16 [snapcast-client-living-room 1/6] FROM docker.io/library/alpine:latest@sha256:4bcff63911fcb4448bd4fdacec207030997caf25e9bea4045fa6c8c44de311d1 #16 resolve docker.io/library/alpine:latest@sha256:4bcff63911fcb4448bd4fdacec207030997caf25e9bea4045fa6c8c44de311d1 0.0s done #16 DONE 0.0s #17 [knxd 1/8] FROM docker.io/library/alpine:edge@sha256:115729ec5cb049ba6359c3ab005ac742012d92bbaa5b8bc1a878f1e8f62c0cb8 #17 resolve docker.io/library/alpine:edge@sha256:115729ec5cb049ba6359c3ab005ac742012d92bbaa5b8bc1a878f1e8f62c0cb8 0.0s done #17 DONE 0.0s #18 [app development 3/4] RUN apt-get update && apt-get install -y curl git procps iputils-ping telnet libvlc-dev libvlccore-dev libvlc5 libvlccore9 vlc-plugin-base && rm -rf /var/lib/apt/lists/* && /usr/lib/aarch64-linux-gnu/vlc/vlc-cache-gen /usr/lib/aarch64-linux-gnu/vlc/plugins #18 CACHED #19 [app development 2/4] WORKDIR /app #19 CACHED #20 [app development 4/4] RUN useradd -m -s /bin/bash -u 1000 vscode && mkdir -p /home/vscode/.nuget/packages && chown -R vscode:vscode /home/vscode #20 CACHED #21 [knxd internal] load build context #21 transferring context: 1.15kB done #21 DONE 0.0s #22 [snapcast-server internal] load build context #22 transferring context: 13.16kB done #22 DONE 0.0s #23 [knxd 2/8] RUN echo "https://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories #23 CACHED #24 [knxd 3/8] RUN apk add --no-cache knxd libusb libev fmt tini net-tools && rm -rf /var/cache/apk/* #24 CACHED #25 [knxd 7/8] RUN chmod +x /usr/local/bin/entrypoint.sh #25 CACHED #26 [knxd 5/8] RUN mkdir -p /var/run/knxd /var/log/knxd /home/knxd/.config /home/knxd/data && chown -R knxd:knxd /var/run/knxd /var/log/knxd /home/knxd #26 CACHED #27 [knxd 4/8] RUN addgroup -g 1000 knxd && adduser -D -u 1000 -G knxd -h /home/knxd -s /bin/sh knxd #27 CACHED #28 [knxd 6/8] COPY entrypoint.sh /usr/local/bin/entrypoint.sh #28 CACHED #29 [snapcast-server runtime 7/8] COPY supervisord.conf /etc/supervisord.conf #29 CACHED #30 [snapcast-server builder 4/5] WORKDIR /build/snapcast #30 CACHED #31 [snapcast-server runtime 4/8] COPY --from=builder /usr/local/bin/snapserver /usr/local/bin/ #31 CACHED #32 [snapcast-server runtime 2/8] RUN apk add --no-cache dumb-init supervisor bash curl alsa-lib flac libvorbis opus soxr openssl ffmpeg #32 CACHED #33 [snapcast-server builder 5/5] RUN git clone --depth 1 --branch v0.31.0 https://github.com/badaix/snapcast.git . && cmake -B build -S . -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_CXX_FLAGS="-O3 -DNDEBUG" -DBUILD_WITH_FLAC=ON -DBUILD_WITH_VORBIS=ON -DBUILD_WITH_OPUS=ON -DBUILD_WITH_AVAHI=OFF -DBUILD_WITH_EXPAT=OFF -DBUILD_TESTS=OFF -DBUILD_CLIENT=OFF && cmake --build build && cmake --install build #33 CACHED #34 [snapcast-server runtime 5/8] RUN wget -qO /tmp/snapweb.zip https://github.com/badaix/snapweb/releases/latest/download/snapweb.zip && unzip -q /tmp/snapweb.zip -d /usr/share/snapserver/snapweb/ && rm /tmp/snapweb.zip #34 CACHED #35 [snapcast-server builder 3/5] RUN mkdir -p /tmp/ccache #35 CACHED #36 [snapcast-server runtime 6/8] COPY --chmod=755 setup.sh /usr/local/bin/snapdog-setup #36 CACHED #37 [snapcast-server builder 2/5] RUN apk add --no-cache build-base cmake git ccache pkgconfig boost-dev alsa-lib-dev flac-dev libvorbis-dev opus-dev soxr-dev openssl-dev ffmpeg-dev #37 CACHED #38 [snapcast-server runtime 3/8] RUN addgroup -g 1000 snapcast && adduser -D -u 1000 -G snapcast -h /var/lib/snapcast snapcast && mkdir -p /var/lib/snapcast /var/lib/snapserver /var/log/supervisor /run/supervisord /snapsinks /etc/snapcast /usr/share/snapserver/snapweb /home/snapcast/.config/snapserver /root/.config/snapserver && chown -R snapcast:snapcast /var/lib/snapcast /var/lib/snapserver /snapsinks /home/snapcast /root/.config/snapserver && chmod 0777 /snapsinks #38 CACHED #39 [knxd 8/8] WORKDIR /home/knxd #39 CACHED #40 [snapcast-client-living-room internal] load build context #40 transferring context: 3.24kB done #40 DONE 0.0s #41 [snapcast-server runtime 8/8] RUN cat > /usr/local/bin/snapdog-entrypoint << 'EOF' && chmod +x /usr/local/bin/snapdog-entrypoint #41 CACHED #42 [snapcast-client-kitchen 4/6] COPY supervisord.conf /etc/supervisord.conf #42 CACHED #43 [snapcast-client-kitchen 5/6] COPY start.sh /start.sh #43 CACHED #44 [snapcast-client-kitchen 2/6] RUN apk update && apk upgrade && apk add --no-cache snapcast-client dumb-init bash supervisor alsa-utils #44 CACHED #45 [snapcast-client-kitchen 3/6] RUN mkdir -p /run/supervisord && mkdir -p /etc/snapclient && mkdir -p /var/log/supervisor #45 CACHED #46 [snapcast-client-living-room 6/6] RUN chmod +x /start.sh #46 CACHED #47 [snapcast-client-kitchen] exporting to image #47 exporting layers done #47 exporting manifest sha256:1e18f4e4659ebd461e31af4224590142204f6fec09419913428d86e74462d30d 0.0s done #47 exporting config sha256:65aa114c9b3f960334107b14562158045a9d1a1e06b0c0c21a31b08c5c6a3871 #47 ... #48 [app] exporting to image #48 exporting layers done #48 exporting manifest sha256:0cd00f4674be7655a4a0e19fa97af860e8ebb4df54b0d7145b5923241332c80a done #48 exporting config sha256:2e2f76e668502894d090e31a288ff7899549884965085f01574b56d3d82cd610 done #48 exporting attestation manifest sha256:8e7fcc55b8fdff4d7f51f5d70e3c73b98265431ce70ee8889d3b0d11793ede27 0.0s done #48 exporting manifest list sha256:bff1764cc3d7ae5479e2e0dba2e040159d25f5ed26bb725ae011f14ba4a7c8a2 0.0s done #48 naming to docker.io/library/snapdog-app:latest 0.0s done #48 unpacking to docker.io/library/snapdog-app:latest 0.0s done #48 DONE 0.1s #47 [snapcast-client-kitchen] exporting to image #47 exporting config sha256:65aa114c9b3f960334107b14562158045a9d1a1e06b0c0c21a31b08c5c6a3871 0.0s done #47 exporting attestation manifest sha256:9a161b0b0e33f52bb15d2fb45da85e528f1b6c870c8574a681640717b6025347 0.0s done #47 exporting manifest list sha256:c7104be902dbe36d82e23f522c6ae94479ba0843472c9e6dcbc7fa611cdc817f 0.0s done #47 naming to docker.io/library/snapdog-snapcast-client-kitchen:latest done #47 unpacking to docker.io/library/snapdog-snapcast-client-kitchen:latest #47 unpacking to docker.io/library/snapdog-snapcast-client-kitchen:latest 0.0s done #47 DONE 0.2s #49 [knxd] exporting to image #49 exporting layers done #49 exporting manifest sha256:8aae0b958098870321479015afef485b08c01ddb6abdfe7c45fc55a6e3716dee done #49 exporting config sha256:6a07b28c56f209942bed18ae905a8ef7f5b5d6062fa0521071dbd54f9bbe148b done #49 exporting attestation manifest sha256:62ae18f5d72bc9b0e0160e49be84181972fd0eb0645633e0ea2e3d8ce58bbdf6 0.0s done #49 exporting manifest list sha256:e06704f0cbe5cf697e8e9022cb5daf5b36d6d6b17a719d0cc03d7f8998ffd4ae 0.0s done #49 naming to docker.io/library/snapdog-knxd:latest done #49 unpacking to docker.io/library/snapdog-knxd:latest 0.0s done #49 DONE 0.1s #50 [snapcast-client-bedroom] exporting to image #50 exporting layers done #50 exporting manifest sha256:0f31795aab59714798c0770d8ca618cdd018e6c88af4aece389472a1f4bbaf36 0.0s done #50 exporting config sha256:5ffdc0a3fc12231fe6914a6455eab5bed50c2a62ac6c57c76b2ad9d5f5e1166d 0.0s done #50 exporting attestation manifest sha256:29c18ecb63c680c50e7125d103dec9ec0365ac1d74ff0095231f3ca3121a2bcd 0.0s done #50 exporting manifest list sha256:df9f3d59af922c823c5c3c4de5b5b2658e2b8116455b68c9d9f413b0c0f79a1e 0.0s done #50 naming to docker.io/library/snapdog-snapcast-client-bedroom:latest done #50 unpacking to docker.io/library/snapdog-snapcast-client-bedroom:latest done #50 DONE 0.2s #51 [snapcast-client-living-room] exporting to image #51 exporting layers done #51 exporting manifest sha256:ea950dda04393ccec4fb9e2108bca30acb0b1065623247a4b20a604b232be280 0.0s done #51 exporting config sha256:e10e7b8a023efb1fa5887b78fbe4266d53307fefa33fb2ab6510388c2f84dd5b 0.0s done #51 exporting attestation manifest sha256:4da7011bb81ba95fe52973309c604caea4b0accde06ac6e86345af24fd42518a 0.0s done #51 exporting manifest list sha256:17fa6cfe6101ece3217ae1ce7100a6ad3258d6796af7d22abdd5502aa6dda0c1 0.0s done #51 naming to docker.io/library/snapdog-snapcast-client-living-room:latest done #51 unpacking to docker.io/library/snapdog-snapcast-client-living-room:latest 0.0s done #51 DONE 0.2s #52 [snapcast-server] exporting to image #52 exporting layers done #52 exporting manifest sha256:ef2b76fd6ffeb6ed5081f37ababb9e7f5c99825435db5cfbabc68ba338ee2517 0.0s done #52 exporting config sha256:d35f174ec06bdea8774c3b29a29b964e336b58eaeb02d34cdd33d3467293ac36 0.0s done #52 exporting attestation manifest sha256:5721fc99b56ab47ed744b0d16141b79664f5e9c3f8115b8d28137b317954660c 0.0s done #52 exporting manifest list sha256:6eda4cdca455510c2c3d7882397b1dfb82d2c241ab4c54d2112ec109125f4f68 0.0s done #52 naming to docker.io/library/snapdog-snapcast-server:latest done #52 unpacking to docker.io/library/snapdog-snapcast-server:latest 0.0s done #52 DONE 0.2s #53 [app] resolving provenance for metadata file #53 ... #54 [snapcast-client-bedroom] resolving provenance for metadata file #54 DONE 0.1s #53 [app] resolving provenance for metadata file #53 DONE 0.1s #55 [snapcast-client-kitchen] resolving provenance for metadata file #55 DONE 0.1s #56 [knxd] resolving provenance for metadata file #56 DONE 0.1s #57 [snapcast-client-living-room] resolving provenance for metadata file #57 DONE 0.0s #58 [snapcast-server] resolving provenance for metadata file #58 DONE 0.0s - ✅ No more path resolution errors - ✅ Config files properly mounted from TestData directory - ✅ App container uses optimized multi-stage build - ✅ Proper network configuration maintained ## Container Build Status - ✅ app: Builds successfully (solution root context) - ✅ mqtt: Builds successfully - ✅ snapcast-server: Builds successfully - ✅ snapcast-client-*: Build successfully - ✅ knxd: Builds successfully The Docker container build infrastructure is now fully functional and ready for integration testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop