Skip to content

Conversation

@traversaro
Copy link
Collaborator

@traversaro traversaro commented Oct 16, 2025

Fix #951 . The problem was the mixing of defaults and conda-forge that is explicitly not supported by conda-forge https://conda-forge.org/docs/user/transitioning_from_defaults/, see also #974 (comment) .

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 16, 2025
@traversaro
Copy link
Collaborator Author

There is still a failure:

=========================== short test summary info ===========================
FAILED test/test_encoders.py::TestAudioEncoder::test_bad_input_parametrized[to_file] - AssertionError: Regex pattern did not match.
 Regex: 'avcodec_open2 failed: Invalid argument'
 Input: 'invalid sample rate=10. Supported sample rate values are: 44100, 48000, 32000, 22050, 24000, 16000, 11025, 12000, 8000'
FAILED test/test_encoders.py::TestAudioEncoder::test_bad_input_parametrized[to_tensor] - AssertionError: Regex pattern did not match.
 Regex: 'avcodec_open2 failed: Invalid argument'
 Input: 'invalid sample rate=10. Supported sample rate values are: 44100, 48000, 32000, 22050, 24000, 16000, 11025, 12000, 8000'
FAILED test/test_encoders.py::TestAudioEncoder::test_bad_input_parametrized[to_file_like] - AssertionError: Regex pattern did not match.
 Regex: 'avcodec_open2 failed: Invalid argument'
 Input: 'invalid sample rate=10. Supported sample rate values are: 44100, 48000, 32000, 22050, 24000, 16000, 11025, 12000, 8000'
FAILED test/test_encoders.py::TestAudioEncoder::test_against_cli[to_file-flac-8000-2-None-asset0] - json.decoder.JSONDecodeError: Expecting ',' delimiter: line 3460 column 10 (char 111086)
==== 4 failed, 959 passed, 364 skipped, 3 deselected in 321.68s (0:05:21) =====

I actually encountered the same problem in conda-forge/torchcodec-feedstock#33 . Basically, the workaround added in 1dd1bc7 are not required for ffmpeg >= 7.1 .

Copy link
Contributor

@Dan-Flores Dan-Flores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great fix @traversaro!

@Dan-Flores Dan-Flores merged commit 546fca7 into meta-pytorch:main Oct 17, 2025
59 checks passed
NicolasHug pushed a commit to NicolasHug/torchcodec that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support FFmpeg8 on Windows

2 participants