Indicate FFmpeg8 support in docs #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
reviewed
Oct 16, 2025
src/torchcodec/_core/ops.py
Outdated
| f"""Could not load libtorchcodec. Likely causes: | ||
| 1. FFmpeg is not properly installed in your environment. We support | ||
| versions 4, 5, 6 and 7. | ||
| versions 4, 5, 6, 7, and 8. |
Contributor
There was a problem hiding this comment.
thanks @Dan-Flores , here and below let's clarify that Windows doesn't support 8 yet.
NicolasHug
approved these changes
Oct 16, 2025
README.md
Outdated
| 1. Install FFmpeg with NVDEC support. | ||
| TorchCodec with CUDA should work with FFmpeg versions in [4, 7]. | ||
| TorchCodec with CUDA should work with FFmpeg versions in [4, 7] on all platforms, | ||
| and FFmpeg version 8 is supported on Mac and Linux. |
Contributor
There was a problem hiding this comment.
This is the part about GPU support, so Mac is not relevant here
Suggested change
| and FFmpeg version 8 is supported on Mac and Linux. | |
| and FFmpeg version 8 is supported on Linux. |
NicolasHug
pushed a commit
to NicolasHug/torchcodec
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Daniel Flores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since support for FFmpeg8 was added for Mac and Linux, we need to update our readme and build error msg to reflect that.