Skip to content

Auto recover last track instead of making a question upon launching the app. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jun 2, 2023
Merged

Auto recover last track instead of making a question upon launching the app. #249

merged 27 commits into from
Jun 2, 2023

Conversation

@merlos
Copy link
Owner

@merlos merlos commented May 28, 2023

Closes #245

If there is a session that is recovered, the application loads it without asking any question to the user. It displays a toast for a few seconds to inform about the automatic recovery.

TODO:

  • Add somewhere in the UI a label to display the current file session name
  • Add some zoom out to pad the recovered file.
    - Think about if current location shall be included in the zoom extent.

Also makes a small change in the code merged in #239

merlos added 18 commits May 28, 2023 11:22
@merlos
Implement toast
02e7efb
@merlos
auto load last session
4043247
@merlos
ensure only tracks are removed if there is one at least
0c02dae
@merlos
remove some spaces
f475f7e
@merlos
remove map view print user interaction
08fd727
@merlos
update all localizable strings using ChatGPT translation
9118dd9
@merlos
fix swiftlint issue in arm64 chips
bce670b
@merlos
remove CoreDataAlertView (no longer being used)
884a2ee
@merlos
fix some lint issues in toast
7cf4b83
@merlos
fix warning variable_name has been renamed to identifier_name
5ea8b44
@merlos
fix error that prevented to compile due too long body in viewcontroller
7f29316
@merlos
fixed warning that mentioned that swiftlint did not have outputs
1f1b4c6
@merlos
Update readme - Add privacy
6f3d352
@merlos
Readme: Update iOS version
b03785c
@merlos
Readme: update contribute section
b2da894
@merlos
Readme: Update supported languages
2c8ea70
@merlos
Readme: small puntualizations & updates
c50295d
@merlos
toast: fix space lint warning
6b3c49c
vincentneo
vincentneo reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@vincentneo vincentneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on UIColor

@merlos merlos marked this pull request as ready for review June 1, 2023 11:27
@merlos
Copy link
Owner Author

merlos commented Jun 1, 2023

ad594e3 partially fixes #250, removes the large majority of the superfluous warnings.

The ones remaining may need some code refactor

@merlos merlos mentioned this pull request Jun 2, 2023
Open
@merlos merlos merged commit 548e8ff into master Jun 2, 2023
@merlos merlos deleted the enhancement/auto-recover-last-track branch June 11, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincentneo vincentneo vincentneo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-recover last track instead of asking

2 participants

@merlos @vincentneo