Skip to content

Fix location permissions warning issue (closes #193) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix location permissions warning issue (closes #193) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions OpenGpxTracker-Watch Extension/InterfaceController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,16 +331,25 @@ class InterfaceController: WKInterfaceController {
/// - Seealso: displayLocationServicesDisabledAlert, displayLocationServicesDeniedAlert
///
func checkLocationServicesStatus() {
//Are location services enabled?
if !CLLocationManager.locationServicesEnabled() {
displayLocationServicesDisabledAlert()
let authorizationStatus = CLLocationManager.authorizationStatus()

//Has the user already made a permission choice?
guard authorizationStatus != .notDetermined else {
//We should take no action until the user has made a choice
return
}

//Does the app have permissions to use the location servies?
if !([.authorizedAlways, .authorizedWhenInUse].contains(CLLocationManager.authorizationStatus())) {
guard [.authorizedAlways, .authorizedWhenInUse ].contains(authorizationStatus) else {
displayLocationServicesDeniedAlert()
return
}

//Are location services enabled?
guard CLLocationManager.locationServicesEnabled() else {
displayLocationServicesDisabledAlert()
return
}
}

///
Expand Down
30 changes: 23 additions & 7 deletions OpenGpxTracker/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,6 @@ class ViewController: UIViewController, UIGestureRecognizerDelegate {
if !wasSentToBackground {
return
}
checkLocationServicesStatus()
locationManager.startUpdatingLocation()
locationManager.startUpdatingHeading()
}
Expand Down Expand Up @@ -1170,16 +1169,26 @@ class ViewController: UIViewController, UIGestureRecognizerDelegate {
/// - Seealso: displayLocationServicesDisabledAlert, displayLocationServicesDeniedAlert
///
func checkLocationServicesStatus() {
//Are location services enabled?
if !CLLocationManager.locationServicesEnabled() {
displayLocationServicesDisabledAlert()
let authorizationStatus = CLLocationManager.authorizationStatus()

//Has the user already made a permission choice?
guard authorizationStatus != .notDetermined else {
//We should take no action until the user has made a choice
//Note that we request location permission as part of the property `locationManager` init
return
}

//Does the app have permissions to use the location servies?
if !([.authorizedAlways, .authorizedWhenInUse].contains(CLLocationManager.authorizationStatus())) {
guard [.authorizedAlways, .authorizedWhenInUse ].contains(authorizationStatus) else {
displayLocationServicesDeniedAlert()
return
}

//Are location services enabled?
guard CLLocationManager.locationServicesEnabled() else {
displayLocationServicesDisabledAlert()
return
}
}
///
/// Displays an alert that informs the user that location services are disabled.
Expand Down Expand Up @@ -1294,8 +1303,6 @@ extension ViewController: PreferencesTableViewControllerDelegate {
signalAccuracyLabel.text = kUnknownAccuracyText
}}

// MARK: location manager Delegate

/// Extends `ViewController`` to support `GPXFilesTableViewControllerDelegate` function
/// that loads into the map a the file selected by the user.
extension ViewController: GPXFilesTableViewControllerDelegate {
Expand Down Expand Up @@ -1418,6 +1425,15 @@ extension ViewController: CLLocationManagerDelegate {
map.updateHeading() // updates heading view's rotation

}

///
/// Called by the system when `CLLocationManager` is created and when the user makes a permission choice
///
/// We handle this delegate callback so that we can check if the user has allowed location access, else we show a warning
///
func locationManagerDidChangeAuthorization(_ manager: CLLocationManager) {
checkLocationServicesStatus()
}
}

extension Notification.Name {
Expand Down