Skip to content

Conversation

@NSMutableString
Copy link
Contributor

Still 80 to go... but coming closer to 0. ;-)

@NSMutableString
Copy link
Contributor Author

58 to go...

@NSMutableString
Copy link
Contributor Author

54 to go.

@vincentneo
Copy link
Collaborator

@NSMutableString,
It's my first time using SwiftLint. I have reduced a little more of the issues.
I wanted to doing my part of clearing some of the mess that I did along the way 😅.

Please do correct me if I have done something wrong, by the way.

@vincentneo
Copy link
Collaborator

@merlos,
Now that we are down to 12 warnings, should merge or continue?

For some warnings I kinda did not want to solve the warning for the sake solving (like function body length violation by a few lines more than recommended)

For some, I don't know how to resolve.

@vincentneo vincentneo requested a review from merlos August 1, 2020 09:44
@merlos merlos merged commit 773f3a3 into merlos:master Sep 28, 2020
@merlos
Copy link
Owner

merlos commented Sep 28, 2020

Thank you guys. I had never used SwiftLint and it helps for having a better code.

PS: Sorry, it took me a while to review.

@NSMutableString NSMutableString deleted the feature/fix-swiftlint-errors branch October 25, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants