Fix media constraints #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested review from
Copilot and
varsill
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses media constraint issues and improves code style consistency across signaling and playback modules. Key changes include updating ICE server configuration formatting, standardizing arrow function syntax and log messages, and bumping the plugin version in the README.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/websocket_signaling/assets/file_to_browser/file_to_browser.js | Improved object literal syntax, consistent arrow function notation, and corrected log message spelling. |
| examples/phoenix_signaling/assets/js/signaling.js | Standardized import formatting, arrow function syntax, and log message corrections in both egress and ingress connection flows. |
| assets/player.js | Fixed spelling in log messages for ICE candidate events. |
| assets/capture.js | Fixed spelling in log messages for ICE candidate events. |
| README.md | Updated dependency version from 0.25.2 to 0.25.3. |
Files not reviewed (2)
- lib/membrane_webrtc/live/capture.ex: Language not supported
- mix.exs: Language not supported
Comments suppressed due to low confidence (3)
examples/websocket_signaling/assets/file_to_browser/file_to_browser.js:33
- Corrected spelling in the ICE candidate log message ('Recieved' to 'Received').
console.log("Received ICE candidate:", data);
examples/phoenix_signaling/assets/js/signaling.js:81
- Fixed typo in the ICE candidate log message for consistency.
console.log("Received ICE candidate:", data);
assets/capture.js:43
- Fixed typo in the ICE candidate log message ('Recieved' should be 'Received').
console.log(`[${this.el.id}] Received ICE candidate:`, data);
| break; | ||
| case `ice_candidate`: | ||
| console.log(`[${this.el.id}] Recieved ICE candidate:`, data); | ||
| console.log(`[${this.el.id}] Received ICE candidate:`, data); |
There was a problem hiding this comment.
Corrected spelling in the log message from 'Recieved' to 'Received'.
varsill
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.