Incorporate Funnel, Tee and Fake.Sink #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
FelonEkonom
changed the title
mat-hek
reviewed
Dec 19, 2024
Comment on lines
3
to
5
| Element that can be used for collecting data from multiple inputs and sending it through one | ||
| output. When a new input connects in the `:playing` state, the funnel sends | ||
| `#{inspect(__MODULE__)}.NewInputEvent` via output. |
There was a problem hiding this comment.
Suggested change
| Element that can be used for collecting data from multiple inputs and sending it through one | |
| output. When a new input connects in the `:playing` state, the funnel sends | |
| `#{inspect(__MODULE__)}.NewInputEvent` via output. | |
| Element that can be used for collecting data from multiple inputs and sending it through one | |
| output. | |
| When a new input connects in the `:playing` state, the funnel sends | |
| `#{inspect(__MODULE__)}.NewInputEvent` via output. |
lib/membrane/tee.ex
Outdated
|
|
||
| It has one input pad `:input` and 2 output pads: | ||
| * `:output` - is a dynamic pad which is always available and works in pull mode | ||
| * `:output_copy` - is a dynamic pad that can be linked to any number of elements (including 0) and works |
There was a problem hiding this comment.
While copy made (a bit of) sense along with the master pad, now it doesn't IMO. Maybe push_output?
| @@ -0,0 +1,12 @@ | |||
| defmodule Membrane.Fake.Sink do | |||
There was a problem hiding this comment.
What about
Suggested change
| defmodule Membrane.Fake.Sink do | |
| defmodule Membrane.FakeSink do |
There was a problem hiding this comment.
In analogical places in core (Testing.Sink, Debug.Filter) we use dots
mat-hek
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #871