handle_child_terminated #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
force-pushed
the
handle-child-terminated
branch
from
8b287af to
010ef5c
Compare
varsill
requested changes
Oct 18, 2024
lib/membrane/bin.ex
Outdated
| @doc """ | ||
| Callback invoked after a child terminates. | ||
| Terminated child won't occur in the callback context. It is allowed to spawn a new child with the same |
There was a problem hiding this comment.
Suggested change
| Terminated child won't occur in the callback context. It is allowed to spawn a new child with the same | |
| Terminated child won't be present in the context of this callback. It is allowed to spawn a new child with the same |
There was a problem hiding this comment.
It also applies to changes in Membrane.Pipeline
| assert_pipeline_notified(pipeline, child, :handle_playing) | ||
| end | ||
|
|
||
| defp assert_grandhild_playing(pipeline, child, grandchild) do |
There was a problem hiding this comment.
Since you are already touching that file, please rename assert_grandhild_playing into assert_grandchild_playing ;)
| use Membrane.Endpoint | ||
| end | ||
|
|
||
| defmodule PadlessElemeentPipeline do |
There was a problem hiding this comment.
Suggested change
| defmodule PadlessElemeentPipeline do | |
| defmodule PadlessElementPipeline do |
CHANGELOG.md
Outdated
|
|
||
| ## 1.1.2 | ||
| * Remove 'failed to insert a metric' stalker warning [#849](https://github.com/membraneframework/membrane_core/pull/849) | ||
| * Add new callback `handle_chiild_terminated/3`. [#894](https://github.com/membraneframework/membrane_core/pull/894) |
There was a problem hiding this comment.
Suggested change
| * Add new callback `handle_chiild_terminated/3`. [#894](https://github.com/membraneframework/membrane_core/pull/894) | |
| * Add new callback `handle_child_terminated/3`. [#894](https://github.com/membraneframework/membrane_core/pull/894) |
There was a problem hiding this comment.
And remember to write about all those assert_handle_child_terminated assertions
lib/membrane/testing/assertions.ex
Outdated
| refution = :"refute_#{action}" | ||
|
|
||
| @doc """ | ||
| Asserts `Membrane.Testing.Pipeline` executed callback `#{callback}/3` for a specific |
There was a problem hiding this comment.
Suggested change
| Asserts `Membrane.Testing.Pipeline` executed callback `#{callback}/3` for a specific | |
| Asserts that `Membrane.Testing.Pipeline` executed callback `#{callback}/3` for a specific |
lib/membrane/testing/assertions.ex
Outdated
| end | ||
|
|
||
| @doc """ | ||
| Refutes that `Membrane.Testing.Pipeline` won't execute callback `#{callback}/3` for |
There was a problem hiding this comment.
Suggested change
| Refutes that `Membrane.Testing.Pipeline` won't execute callback `#{callback}/3` for | |
| Refutes that `Membrane.Testing.Pipeline` will execute callback `#{callback}/3` for |
varsill
approved these changes
Oct 18, 2024
CHANGELOG.md
Outdated
|
|
||
| ## 1.1.2 | ||
| * Remove 'failed to insert a metric' stalker warning [#849](https://github.com/membraneframework/membrane_core/pull/849) | ||
| * Add new callback `handle_chiild_terminated/3` along with new assertions. [#894](https://github.com/membraneframework/membrane_core/pull/894) |
There was a problem hiding this comment.
Suggested change
| * Add new callback `handle_chiild_terminated/3` along with new assertions. [#894](https://github.com/membraneframework/membrane_core/pull/894) | |
| * Add new callback `handle_child_terminated/3` along with new assertions. [#894](https://github.com/membraneframework/membrane_core/pull/894) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #889