Remove 'failed to insert a metric' stalker warning #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
changed the title
FelonEkonom
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #814
Even though I cannot reproduce this, as far as I could figure out, this warning can still happen when the pipeline is terminating. Because the supervisor is shutting down the pipeline's children and utility processes in parallel, the stalker can be terminated before some child is terminated, and that child may try inserting metrics into the ETS, which no longer exists. Fixing this would require introducing complex logic into the supervisor while bringing minor benefits to the stalker, so I decided to convert the warning into a debug.