Playback refactor #432
Merged
Playback refactor #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
force-pushed
the
playback
branch
3 times, most recently
from
8ecc0bb to
a3e3b13
Compare
mat-hek
force-pushed
the
playback
branch
4 times, most recently
from
bef52be to
71f25e7
Compare
bblaszkow06
reviewed
Oct 10, 2022
Comment on lines
+47
to
+49
| @spec format(path_t()) :: String.t() | ||
| def format(path) do | ||
| Enum.join(path) |
There was a problem hiding this comment.
That means it is not used - it could be private. And since it's just one call, you can use Enum.join directly in get_formatted
Co-authored-by: Bartosz Błaszków <[email protected]>
bblaszkow06
approved these changes
Oct 10, 2022
* supervisors refactor * resource guard * add utility supervisor to context * refactor element tests not to use State.new * Update lib/membrane/resource_guard.ex Co-authored-by: Bartosz Błaszków <[email protected]> * run resource cleanup in a separate process * refactor observability setup * improve children supervisor API * add docs and test for utility supervisor and resource guard * add timeout to resource * use a boring function name instead of go_brrr * unlink cleanup task in resource guard before killing it * Add list of available callbacks in each component (#449) * Add an aggregated list of all callbacks that can be implemented by `Filter`, `Endpoint`, `Source` and `Sink` element behaviours. Co-authored-by: Mateusz Front <[email protected]> * add docs for Observability.setup Co-authored-by: Bartosz Błaszków <[email protected]> Co-authored-by: Łukasz Kita <[email protected]>
* handle_terminate_request in parent * add handle_terminate_request to element * fix unlinking pads * add terminate action type to element and bin * Rewrite espec tests (#452) * Remove unecessary ESpec tests * Rewrite some crucial ESpec tests * Unify the support modules from ExUnit and ESpec * fix linking test * fix resource guard test * Apply suggestions from code review Co-authored-by: Bartosz Błaszków <[email protected]> Co-authored-by: Łukasz Kita <[email protected]> * Update lib/membrane/bin.ex Co-authored-by: Bartosz Błaszków <[email protected]> * CallbackContext.Other -> Info * fix typos <3 * Callback contexts for handle_terminate_request * add docs for zombies * use ResourceGuard to report termination via telemetry * Add a test to check the links between processes in the pipeline_test.exs. Fix the bug in the test case * add deferred termination tests * add description for children supervisor * fix RC in child removal test * ChildrenSupervisor -> SubprocessSupervisor Co-authored-by: Łukasz Kita <[email protected]> Co-authored-by: Bartosz Błaszków <[email protected]>
varsill
reviewed
Oct 14, 2022
* fix spawning children on remote nodes * remove redundant checks in element and bin
* termporairly fix distribution * re-enable filter aggregator tests * make filter aggregator work again * add context to handle_init * unify handle_init default impl across components * filter aggregator test improvements * remove redundant match
Co-authored-by: Łukasz Kita <[email protected]>
varsill
reviewed
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://membraneframework.atlassian.net/wiki/spaces/MEMBRANEFR/pages/8978457/Playback+states+refactor
TODO: