feat: Add optional IronRDP server for remote viewing/control #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rdp_server.rs with complete RDP server implementation - Configure optional 'rdp' feature flag in Cargo.toml with rustls backend - Integrate RDP server into stdio and sse transports via --rdp flag - Add --rdp-bind CLI argument for custom RDP bind address - Support desktop capture streaming at configurable FPS - Add input event handling for mouse/keyboard control - RDP server runs on separate tokio task alongside MCP server - HTTP transport shows helpful warning about RDP incompatibility Dependencies added (optional, behind 'rdp' feature): - ironrdp v0.13.0 - ironrdp-async v0.7.0 - ironrdp-pdu v0.6.0 - ironrdp-tls v0.1.4 with rustls backend Usage: cargo build --features rdp terminator-mcp-agent -t stdio --rdp terminator-mcp-agent -t sse --rdp --rdp-bind 0.0.0.0:3389
Changes: - Removed RDP integration from stdio transport (was wrong) - Removed RDP integration from sse transport (was wrong) - Fixed HTTP transport to properly support RDP via eager initialization - When --rdp flag is set with HTTP transport, DesktopWrapper is created eagerly - This allows RDP server to start alongside HTTP MCP server - Maintains lazy init when RDP is disabled (preserves CI health check behavior) User feedback: "why the fuck only sse and not http? its unrelated and we dont care about sse acutally and stdio, it should only be for http" Next steps: - Complete bitmap encoding in rdp_server.rs (lines 151-154) - Complete input handling in rdp_server.rs (lines 171-221) - Deploy to Azure VM and test with Microsoft RDP client Part of PR #316
Explains: - What's working (HTTP integration, screen capture infrastructure) - What's not working yet (full RDP protocol, bitmap encoding, input handling) - Why implementation is incomplete (RDP protocol complexity) - Three options forward: complete RDP, switch to VNC, or deploy MVP - Estimated effort for each option - Testing instructions This is an honest assessment of the current MVP state.
Complete step-by-step guide covering: - Azure VM creation (Windows and Ubuntu options) - Build and deployment instructions - Testing procedures from local machine - Firewall configuration - Monitoring and debugging - Cost optimization tips - Troubleshooting common issues Enables testing of current RDP MVP implementation on cloud VM.
Executive summary covering: - What was fixed (HTTP-only integration per user feedback) - Current MVP status (what works vs what doesn't) - Effort assessment (2-3 days for full RDP vs 4-6 hours for VNC) - Three deployment options with pros/cons - Usage instructions and recommendations - All files changed and documentation created Honest assessment: Infrastructure works, full RDP protocol incomplete. Clear decision points for next steps.
- Add ironrdp-acceptor and ironrdp-server dependencies - Implement RdpServerInputHandler for mouse/keyboard events - Implement RdpServerDisplay for bitmap screen updates - Use ironrdp-server's high-level API instead of low-level protocol - Replace partial handshake with full protocol implementation - Convert RGBA screenshots to RGB24 format for RDP - Ready for deployment to Azure VM for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements IronRDP server as an optional feature for remote desktop viewing and control of Terminator MCP sessions.
Changes
Features
cargo build --features rdp--rdpand--rdp-bind(default: 127.0.0.1:3389)Usage
Transport Support
Dependencies Added (optional)
Testing
Implementation Notes
Future Enhancements
Closes #[issue-number-if-exists]