fix: use scopes_supported in OAuth server metadata
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
gao-sun
approved these changes
Jul 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the OAuth metadata property name to match RFC8414 by replacing scope_supported with scopes_supported and adjusts tests and type definitions accordingly.
- Tests now mock and assert the new
scopes_supported(server response) andscopesSupported(client output) fields for both OAuth and OIDC - OAuth types (
authorizationServerMetadataObject) have replacedscope_supportedwithscopes_supportedand updated the inline documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mcp-auth/src/utils/fetch-server-config.test.ts | Added scopes_supported to mocked well-known responses and assertions |
| packages/mcp-auth/src/types/oauth.ts | Replaced scope_supported with scopes_supported in the Zod schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC, the supported scopes filed name should be
scopes_supportedrather thanscope_supported.