Should use transformBundle

[letmaik]

When using plugins like uglify then this ascii transform is run too early. Specifically, uglify re-encodes strings and runs in the transformBundle phase (after transform). By using transformBundle the transformation happens right at the end.

[mbostock]

Sounds reasonable. You’d need to change the Acorn parse options since they currently assume the input source is written as an ES6 module ({ecmaVersion: 6, sourceType: "module"}). Want to send a PR?

[letmaik]

I tried it locally by just switching to transformBundle and removing the id stuff and filter as that's not relevant at that phase, and it works flawlessly. So Acorn seems happy even though it's not a strict ES6 module (having at least one import or export statement).

[Finesse]

transformBundle is removed, the modern equivalent is renderChunk.

Sorry, but this doesn’t look right to me because it ignores the created filter and the options.include and options.exclude. I could see removing the ".js" file extension requirement, as that is not configurable, but I’m not sure what the recommended best practice is here.

You should add an option that switches the plugin from input transformation mode to output transformation mode. The filter can be applied either to the input files or the output chunks depending on this setting value.

P.S. My use case is compiling a TypeScript project together with @rollup/plugin-typescript.