-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Description
In https://github.com/maxogden/abstract-blob-store/pull/31/files#diff-f763f1634ff40f723dd8de924120ce55R60 a new test was added to check for the presence of err.notFound on blobs that aren't found and released as semver minor. I believe this to be a semver mistake, as its breaking downstream blob store tests in non-breaking semver ranges.
What should be done:
- Skip the
t.ok(e.notFound, 'error reports not found')
test and release as a patch release in 3.0.0 major family. - Document the
error.notFound = true
property in the spec and re-add the test and release as 4.0.0 with release notes regarding the change.
Metadata
Metadata
Assignees
Labels
No labels