add convertation from YUYV to h264, now QGroundControl can see our st… #369
+40
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream, fix ssl in Dockerfile, update docker/build_and_run.sh now container can see all our cameras
patrickelectric
approved these changes
Mar 27, 2024
patrickelectric
requested changes
Mar 27, 2024
Comment on lines
-81
to
+83
| " ! capsfilter name={filter_name} caps=video/x-raw,format=I420,width={width},height={height},framerate={interval_denominator}/{interval_numerator}", | ||
| " ! x264enc", | ||
| " ! h264parse", | ||
| " ! capsfilter name={filter_name} caps=video/x-h264,stream-format=avc,alignment=au,width={width},height={height},framerate={interval_denominator}/{interval_numerator}", |
There was a problem hiding this comment.
I believe that we can accomplish the same thing with decodebin3 here, and letting it taking decision over the encoders. @joaoantoniocardoso what you think ?
There was a problem hiding this comment.
Yeah, we could use encodebin/encodebin2 to be more robust.
I believe transcoding should be an option, and not change today's default behavior, as people might be using raw video streams right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ream, fix ssl in Dockerfile, update docker/build_and_run.sh now container can see all our cameras