Send packet only with POST method.

[nostromoo]

Closes #468

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.99%. Comparing base (a6a7260) to head (72de688).
⚠️ Report is 192 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #470      +/-   ##
============================================
- Coverage     87.12%   86.99%   -0.14%     
+ Complexity      364      358       -6     
============================================
  Files            32       32              
  Lines          1429     1422       -7     
  Branches        165      162       -3     
============================================
- Hits           1245     1237       -8     
- Misses          115      116       +1     
  Partials         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hannesa2]

@d4rken
When I understand right, you did in 1f8ccd6 this decision if it's a get or a post by asking batch.size(), am I right ?

Do you agree with these changes ?

[d4rken]

I don't remember why I did it this way 🤔.

Might have been an optimization, i.e. GET having less overhead than POST for single events. In hindsight I don't think the overhead would be huge enough to warrant both GET and POST.

I'm neutral on this change.

@nostromoo Please consider adding some descriptions to your PRs. What made you change this?

[hannesa2]

Like @d4rken I'm neutral on this change too.
We can give it a try

[hannesa2]

@nostromoo
Please test it first
implementation 'com.github.nostromoo:matomo-sdk-android:remove_get_packet-SNAPSHOT'
if it comes now with desired behavior. If yes, I'll merge it.

Please keep me informed

[d4rken]

Now I see the linked #468.

Did something change on the server-side? According to docs (the last time I checked) the server should accept both GET and POST. 🤷

This could warrant further debugging to find out why GET is not working. Broken in the SDK? Or an issue with the server config?

If it's the later, changing the SDK seems like the wrong way to fix it 😁.

[hannesa2]

Now I see the linked #468.

I did it

[hannesa2]

If it's the later, changing the SDK seems like the wrong way to fix it 😁.

Any suggestion what's the right way

[d4rken]

If it's the later, changing the SDK seems like the wrong way to fix it 😁.

Any suggestion what's the right way

Check if single GET requests are reaching the server, and if they are, check why the server is not processing them. Removing the GET and only using POST is fine, but shouldn't be done as a "guess" without understanding why GET is not working.

@mattab Did the server's behavior for GET change?