-
Notifications
You must be signed in to change notification settings - Fork 1
Make the repo Slackware compatible #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this facilitates installing/updating with un-get
since their repo doesn't have those instructions ¯\_(ツ)_/¯
WalkthroughAdds a Slackware repo metadata generator script, integrates README templating and repo updates into the build workflow, and adds repository metadata entries and a README template for the fish package. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Runner as GitHub Actions Runner
participant WF as build-fish.yml
participant FS as Workspace FS
participant Script as generate-repo-files.sh
participant Git as Git Remote
Runner->>WF: start job (release/build)
WF->>FS: create slackware/ folders
WF->>FS: move built package -> slackware/fish/
WF->>FS: render README.md from README.md.template (env placeholders)
WF->>Script: execute Script (cwd: slackware)
Script->>FS: scan files, collect stat metadata -> FILE_LIST.tmp
Script->>FS: compute md5s -> CHECKSUMS.md5.tmp
Script->>FS: atomically rename tmp files -> FILE_LIST, CHECKSUMS.md5
WF->>FS: git add README, slackware/*
WF->>Git: commit & push (if not skipped)
Git-->>WF: push result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/scripts/generate-repo-files.sh
(1 hunks).github/workflows/build-fish.yml
(4 hunks)README.md
(1 hunks)README.md.template
(1 hunks)slackware/CHECKSUMS.md5
(1 hunks)slackware/FILELIST.TXT
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
32-32: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/scripts/generate-repo-files.sh
(1 hunks).github/workflows/build-fish.yml
(4 hunks)README.md
(1 hunks)README.md.template
(1 hunks)slackware/CHECKSUMS.md5
(1 hunks)slackware/FILE_LIST
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- slackware/FILE_LIST
🚧 Files skipped from review as they are similar to previous changes (2)
- README.md.template
- slackware/CHECKSUMS.md5
🔇 Additional comments (1)
README.md (1)
23-24
: ...Also applies to: 38-38
it will only be one line
This facilitates installing/updating with https://github.com/ich777/un-get
Note: I've changed it so that
README.md.template
gets copied toREADME.md
, and then the template string substitutions are performed. This means that future changes to the README should be made in the template file. I hope that's okay with you.Summary by CodeRabbit
New Features
Documentation
Chores