Fix missing include #280
Open
Fix missing include #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
date_time.hpp was not including std_optional.hpp directly. It probably got it transitively from other files including it directly. This caused clangd to complain at every `#include <toml++/toml.hpp>`
marzer
reviewed
Aug 19, 2025
| @@ -7,6 +7,7 @@ | |||
| #include "forward_declarations.hpp" | |||
| #include "print_to_stream.hpp" | |||
| #include "header_start.hpp" | |||
| #include "std_optional.hpp" | |||
There was a problem hiding this comment.
Order matters here; header_start.hpp needs to be the last include. Then this will be gucci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date_time.hpp was not including std_optional.hpp directly. It probably got it transitively from other files including it directly. This caused clangd to complain at every
#include <toml++/toml.hpp>What does this change do?
Adds a missing include
Is it related to an exisiting bug report or feature request?
No
Pre-merge checklist
origin/master(if necessary)