Fixed not working silent refresh when using 'code' #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window.location.search is "" when using the iframe. The querySource seems to have the correct value
Collaborator
|
Wow, amazing! Is that truly all that is needed to fix the issue, while keeping things working for other flows and code paths?! 😮 If so: fantastic! 💖 |
Contributor
Author
|
I tested it on my own code, it seems to do the job ;) |
|
I came to the same fix and it seems to make sense for both paths. |
Owner
|
That's great. Thanks! I'll make a 9.1 release ready soon. |
Owner
|
Wow, I had no idea that it would be THAT easy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.location.search is "" when using the iframe.
The querySource seems to have the correct value
A fix for #600