Skip to content

Fixed not using config.openUri in code flow #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fixed not using config.openUri in code flow #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions projects/lib/src/oauth-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,13 +2168,12 @@ export class OAuthService extends AuthConfig implements OnDestroy {
throw new Error('loginUrl must use Http. Also check property requireHttps.');
}

this.createLoginUrl(additionalState, '', null, false, params).then(function (url) {
location.href = url;
})
.catch(error => {
console.error('Error in initAuthorizationCodeFlow');
console.error(error);
});
this.createLoginUrl(additionalState, '', null, false, params)
.then(this.config.openUri)
.catch(error => {
console.error('Error in initAuthorizationCodeFlow');
console.error(error);
});
}

protected async createChallangeVerifierPairForPKCE(): Promise<[string, string]> {
Expand Down