During session check, ignore messages with irrelevant origin #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling messages from other iframes makes no sense and leads to memory leaks.
jeroenheijmans
approved these changes
Aug 27, 2019
Collaborator
|
Looks good to me. |
Contributor
Author
|
Thank you! Would you merge it in? |
Collaborator
|
No, sorry. At the time of writing I'm only moderating issues and doing initial checks for PRs, leaving merges and changes to the maintainer for the moment (who typically sets some time aside once in every while to do updates and release new version(s)). |
Contributor
Author
|
Ok, thanks for letting me know! Looking forward to the release containing this fix |
Contributor
Author
|
@manfredsteyer could you please give a hint about when do you plan to merge this (and probably other PRs) and release a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling messages from other iframes makes no sense and leads to memory leaks. Fixes #616