Add noPrompt parameter to setupAutomaticSilentRefresh method #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is there an issue related to this? I'm actually confused you can configure it for the other method in the first place, doesn't "silent" imply it should always have noprompt anyways? On a technical note about the proposed changes, I suggest not adding the parameter in the middle, as that would be an unnecessary breaking change I think? Making it the last parameter would allow existing callers to keep functioning as they were before. Either way, many thanks for your contribution of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
noPromptparameter was already present in thesilentRefreshmethod but it wasn't in thesetupAutomaticSilentRefreshmethod