Calculate the timeout using now as a reference #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't do this, we could wait too long after a refresh of the app. We still use the storedAt variable to determine when we are in the last chunk (gray zone) of time (using the timeoutFactor), en make negative Delta's 0 (zero).
|
Would this fix #444? |
|
Ping @manfredsteyer |
Contributor
|
@orditeck |
Contributor
|
Any progress concerning this issue? |
Contributor
Author
|
@manfredsteyer would be awesome I you could find the time to look at this 😃 |
|
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix to solve what is described in #467
If we don't do this, we could wait too long after a refresh of the app. We still use the storedAt variable to determine when we are in the last chunk (gray zone) of time (using the timeoutFactor), and make negative Delta's 0 (zero). co-creds go to @RubenVermeulen
! We have not yet had the chance to test this fix.