Added option to set up silent refresh only for certain type of token. #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thx, that's great! |
|
@martin1cerny Although the option is added to filter token_expires based on the listenTo parameter, the code that sets up the timers setupExpirationTimers() still continues to use the shorter expiring time which will be id_token. I dont think the issue is still fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ID token often has significantly shorter expiry time compared to access token. This PR adds a non-destructive option to
setupAutomaticSilentRefresh()which allows to only watch for certain kind of token expiry. This also solves issue #432.