Use responseType parameter #397
Conversation
Check user requestType paramater before apply default responseType. So the user can define the behavior. Closes: manfredsteyer#385 See: manfredsteyer#385
|
The changes look backwards compatible to me, no existing implementations would be broken AFAICT. Out of curiosity I read through 8.4 from RFC 6749 which seems to be about this part of OAuth2. I had never known that there could even be whole other types of One remark about the proposed PR though: it might be good to add documentation to |
|
@mpbalmeida Great work, I could really do with this change too. I agree with @jeroenheijmans it would be good to add the doc to the AuthConfig class. I have also raised a support issue with AWS, I may be wrong, but I don't think they are fully compliant with the spec. |
glambkin
left a comment
glambkin
left a comment
There was a problem hiding this comment.
Could you add a doc to the AuthConfig responseType and remove the whitespace commits?
| this.responseType = this.config.responseType; | ||
| } else { | ||
| this.responseType = 'token'; | ||
| if (this.oidc && this.requestAccessToken) { |
There was a problem hiding this comment.
could be else if, too, right? That would simplify this if/else/else if complexity, I think :)
|
One comment, otherwise I would love to see this merged and released :) |
|
Thx |
5 participants
Check user requestType paramater before apply default responseType. So the user can define the behavior.
Closes: #385
See: #385