fix: run tokensetup outside ngzone #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@manfredsteyer any input here? |
|
Would be really nice to have this pulled in... this library breaks e2e testing for any applications that use it. Is this project dead or ready for a fork? |
Contributor
Author
Owner
|
;-) Yes, I'm still alive ;-) Thanks for this! |
Owner
|
Thx |
|
Please also merge this fix back to version 3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using this library results into loss of angular-sync in protractor tests due to pending macro tasks, see screenshot:
according to the protractor docs, one should run those long running tasks outside of ngzone.
this PR accomplishes that, our protractor tests don't run into timeouts
however, it seems that this repo doesnt provide any tests for the lib, so I am unsure if this change breaks something...