Skip to content

Protected vs private type definitions #439

@jdgeier

Description

@jdgeier

I have a few specific implementations where I need to override some of the methods and extend OAuthService. Is there a specific reason why all the properties are private instead of protected? For instance I'd like to override loadJwks or loadDiscoveryDocument without having to copy a lot of the other code. Unfortunately I have some services that use proprietary crap that breaks normal oidc flows. I mean I suppose I could fork the repo and switch them all for myself but I'm mostly just curious what they are private instead of protected?

Metadata

Metadata

Assignees

No one assigned

    Labels

    future-versionWill be considered, but for a future version.pr-welcomeWe'd welcome a PR to solve the issue.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions