Skip to content

Conversation

@prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Apr 1, 2024

Problem

Removing parent from issue edit modal pop up is not removing the parent child relation.

Solution

This was due to the use of SetValue to remove parent_id when we click on the cross icon. Our revalidation mode is set to onChange and due this the above logic was not working and dirtyFields was not showing parent_id as an updated field even if the relation was removed. To fix this, I have updated the logic to use <Controller /> component with its onChange prop to remove the relation.

This PR is linked to WEB-848

@prateekshourya29 prateekshourya29 self-assigned this Apr 1, 2024
@prateekshourya29 prateekshourya29 added 🐛bug Something isn't working 🌐frontend labels Apr 1, 2024
@pushya22 pushya22 added this to the v0.18.0-dev milestone Apr 2, 2024
@rahulramesha rahulramesha merged commit fed5916 into develop Apr 3, 2024
@rahulramesha rahulramesha deleted the fix/issue-modal-parent-relation branch April 3, 2024 12:34
aaryan610 pushed a commit that referenced this pull request Sep 30, 2025
* chore: added nested pages in teamspace

* chore: changed the view set

* chore: added restore endpoint for project pages

* chore: added query parameters for listing archived pages

* fix: added support for nested pages

* fix: archive and move pages are present

* chore: added sub pages count

* chore: removed the duplicated code

* chore: changed the entity name for teamspace

* fix: teamspace bugs

* chore: added the sub pages filter

* fix: feature flag added

* fix: teamspace pages ff removed

* chore: added the parent select relataed

* fix: lint issues

---------

Co-authored-by: Palanikannan M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants