Skip to content

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Nov 6, 2023

  1. Render the estimate property in the list and Kanban layout only if estimates are enabled for a particular project.
  2. Update the naming convention of displayProperties props.

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Nov 6, 2023
@aaryan610 aaryan610 added this to the 0.14-dev milestone Nov 6, 2023
@aaryan610 aaryan610 marked this pull request as draft November 6, 2023 09:27
@vercel
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm
plane-dev ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm
plane-sh ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm
plane-staging ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 1:41pm

@aaryan610 aaryan610 marked this pull request as ready for review November 6, 2023 13:41
@sriramveeraghanta sriramveeraghanta merged commit a6dea3a into develop Nov 6, 2023
gwokwong added a commit to gwokwong/plane that referenced this pull request Nov 7, 2023
* develop: (419 commits)
  添加源
  fix: bug fixes and ui improvement (makeplane#2674)
  fix: slack integration workflow (makeplane#2675)
  fix: In kanban issues can be shifted between the column in order_by (makeplane#2676)
  chore: update avatar group logic (makeplane#2672)
  style: updated layouts UI in the space app (makeplane#2671)
  fix: render the estimate select if estimate is enabled for the project (makeplane#2663)
  Fix/mentions spaces fix (makeplane#2667)
  dev: On Demand Code Build for any branch (makeplane#2668)
  fix: existing issues modal for cycle and module (makeplane#2664)
  fix: package version fixes and mentions build error fixes (makeplane#2665)
  fix: notifications option in the sidebar menu not collapsing (makeplane#2662)
  fix: handled drag and drop issue, gantt hover issue for issue peek overview (makeplane#2660)
  refactor: removed unused packages (makeplane#2658)
  fix: product tour modal bugs (makeplane#2657)
  [feat]: Extended Tables Support (makeplane#2596)
  fix: mentions enter error (makeplane#2646)
  chore : dropdown loading state added and project card avatar fix (makeplane#2643)
  refactor: archive issue  (makeplane#2628)
  fix: open changelog in new tab (makeplane#2645)
  ...

# Conflicts:
#	apiserver/Dockerfile.api
#	apps/app/Dockerfile.web
#	apps/app/components/analytics/custom-analytics/create-update-analytics-modal.tsx
#	apps/app/components/analytics/custom-analytics/custom-analytics.tsx
#	apps/app/components/analytics/custom-analytics/sidebar.tsx
#	apps/app/components/analytics/project-modal.tsx
#	apps/app/components/automation/auto-archive-automation.tsx
#	apps/app/components/automation/auto-close-automation.tsx
#	apps/app/components/automation/select-month-modal.tsx
#	apps/app/components/command-palette/command-k.tsx
#	apps/app/components/core/filters/filters-list.tsx
#	apps/app/components/core/filters/issues-view-filter.tsx
#	apps/app/components/core/modals/bulk-delete-issues-modal.tsx
#	apps/app/components/core/sidebar/links-list.tsx
#	apps/app/components/core/sidebar/sidebar-progress-stats.tsx
#	apps/app/components/core/theme/custom-theme-selector.tsx
#	apps/app/components/core/views/all-views.tsx
#	apps/app/components/core/views/board-view/all-boards.tsx
#	apps/app/components/core/views/board-view/single-board.tsx
#	apps/app/components/core/views/calendar-view/calendar-header.tsx
#	apps/app/components/core/views/calendar-view/single-date.tsx
#	apps/app/components/core/views/issues-view.tsx
#	apps/app/components/core/views/list-view/single-list.tsx
#	apps/app/components/core/views/spreadsheet-view/single-issue.tsx
#	apps/app/components/core/views/spreadsheet-view/spreadsheet-columns.tsx
#	apps/app/components/core/views/spreadsheet-view/spreadsheet-view.tsx
#	apps/app/components/cycles/sidebar.tsx
#	apps/app/components/cycles/single-cycle-card.tsx
#	apps/app/components/estimates/create-update-estimate-modal.tsx
#	apps/app/components/issues/comment/add-comment.tsx
#	apps/app/components/issues/delete-issue-modal.tsx
#	apps/app/components/issues/description-form.tsx
#	apps/app/components/issues/gantt-chart/blocks.tsx
#	apps/app/components/issues/modal.tsx
#	apps/app/components/issues/my-issues/my-issues-select-filters.tsx
#	apps/app/components/issues/my-issues/my-issues-view.tsx
#	apps/app/components/issues/select/label.tsx
#	apps/app/components/issues/select/project.tsx
#	apps/app/components/issues/sidebar-select/label.tsx
#	apps/app/components/issues/sidebar-select/state.tsx
#	apps/app/components/issues/sub-issues-list.tsx
#	apps/app/components/issues/view-select/assignee.tsx
#	apps/app/components/issues/view-select/due-date.tsx
#	apps/app/components/issues/view-select/label.tsx
#	apps/app/components/issues/view-select/priority.tsx
#	apps/app/components/issues/view-select/start-date.tsx
#	apps/app/components/labels/single-label-group.tsx
#	apps/app/components/labels/single-label.tsx
#	apps/app/components/modules/sidebar-select/select-lead.tsx
#	apps/app/components/modules/sidebar-select/select-members.tsx
#	apps/app/components/modules/sidebar.tsx
#	apps/app/components/modules/single-module-card.tsx
#	apps/app/components/onboarding/invite-members.tsx
#	apps/app/components/onboarding/user-details.tsx
#	apps/app/components/profile/profile-issues-view.tsx
#	apps/app/components/project/settings-header.tsx
#	apps/app/components/project/settings/single-label.tsx
#	apps/app/components/project/single-project-card.tsx
#	apps/app/components/tiptap/extensions/index.tsx
#	apps/app/components/tiptap/slash-command/index.tsx
#	apps/app/components/views/form.tsx
#	apps/app/components/views/gantt-chart.tsx
#	apps/app/components/views/select-filters.tsx
#	apps/app/components/views/single-view-item.tsx
#	apps/app/components/workspace/issues-stats.tsx
#	apps/app/components/workspace/settings-header.tsx
#	apps/app/components/workspace/sidebar-quick-action.tsx
#	apps/app/constants/calendar.ts
#	apps/app/constants/filters.ts
#	apps/app/constants/project.ts
#	apps/app/helpers/calendar.helper.ts
#	apps/app/layouts/auth-layout/project-authorization-wrapper.tsx
#	apps/app/layouts/auth-layout/user-authorization-wrapper.tsx
#	apps/app/layouts/auth-layout/workspace-authorization-wrapper.tsx
#	apps/app/layouts/profile-layout.tsx
#	apps/app/layouts/settings-navbar.tsx
#	apps/app/package.json
#	apps/app/pages/[workspaceSlug]/analytics.tsx
#	apps/app/pages/[workspaceSlug]/index.tsx
#	apps/app/pages/[workspaceSlug]/me/my-issues.tsx
#	apps/app/pages/[workspaceSlug]/me/profile/index.tsx
#	apps/app/pages/[workspaceSlug]/me/profile/preferences.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/archived-issues/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/cycles/[cycleId].tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/cycles/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/inbox/[inboxId].tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/issues/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/modules/[moduleId].tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/pages/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/automations.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/control.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/estimates.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/features.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/integrations.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/labels.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/members.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/states.tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/views/[viewId].tsx
#	apps/app/pages/[workspaceSlug]/projects/[projectId]/views/index.tsx
#	apps/app/pages/[workspaceSlug]/projects/index.tsx
#	apps/app/pages/[workspaceSlug]/settings/index.tsx
#	apps/app/pages/[workspaceSlug]/settings/members.tsx
#	apps/app/pages/api/slack-redirect.ts
#	apps/app/pages/create-workspace.tsx
#	apps/app/pages/index.tsx
#	apps/app/pages/invitations.tsx
#	apps/app/pages/magic-sign-in.tsx
#	apps/app/pages/onboarding.tsx
#	apps/app/pages/reset-password.tsx
#	apps/app/pages/workspace-member-invitation.tsx
#	apps/space/Dockerfile.space
#	apps/space/components/issues/filters-render/date.tsx
#	apps/space/components/issues/filters-render/index.tsx
#	apps/space/components/issues/filters-render/priority/index.tsx
#	docker-compose.yml
#	space/components/accounts/email-code-form.tsx
#	space/components/accounts/email-password-form.tsx
#	space/components/accounts/email-reset-password-form.tsx
#	web/components/analytics/scope-and-demand/demand.tsx
#	web/components/analytics/scope-and-demand/scope-and-demand.tsx
#	web/components/analytics/scope-and-demand/scope.tsx
#	web/components/auth-screens/workspace/not-a-member.tsx
#	web/components/command-palette/issue/change-issue-priority.tsx
#	web/components/command-palette/shortcuts-modal.tsx
#	web/components/core/activity.tsx
#	web/components/core/modals/existing-issues-list-modal.tsx
#	web/components/core/modals/image-upload-modal.tsx
#	web/components/core/modals/link-modal.tsx
#	web/components/estimates/delete-estimate-modal.tsx
#	web/components/estimates/estimate-list-item.tsx
#	web/components/inbox/filters-dropdown.tsx
#	web/components/inbox/filters-list.tsx
#	web/components/inbox/main-content.tsx
#	web/components/inbox/modals/select-duplicate.tsx
#	web/components/integration/delete-import-modal.tsx
#	web/components/integration/jira/give-details.tsx
#	web/components/integration/jira/import-users.tsx
#	web/components/issues/activity.tsx
#	web/components/issues/comment/comment-card.tsx
#	web/components/issues/draft-issue-form.tsx
#	web/components/issues/parent-issues-list-modal.tsx
#	web/components/issues/peek-overview/issue-properties.tsx
#	web/components/issues/select/assignee.tsx
#	web/components/issues/select/priority.tsx
#	web/components/issues/select/state.tsx
#	web/components/issues/sidebar-select/assignee.tsx
#	web/components/issues/sidebar-select/priority.tsx
#	web/components/issues/sidebar.tsx
#	web/components/labels/create-label-modal.tsx
#	web/components/labels/create-update-label-inline.tsx
#	web/components/labels/delete-label-modal.tsx
#	web/components/labels/labels-list-modal.tsx
#	web/components/modules/delete-module-modal.tsx
#	web/components/modules/form.tsx
#	web/components/notifications/select-snooze-till-modal.tsx
#	web/components/onboarding/tour/root.tsx
#	web/components/onboarding/workspace.tsx
#	web/components/pages/delete-page-modal.tsx
#	web/components/pages/page-form.tsx
#	web/components/pages/pages-list/recent-pages-list.tsx
#	web/components/pages/pages-view.tsx
#	web/components/project/confirm-project-member-remove.tsx
#	web/components/project/create-project-modal.tsx
#	web/components/project/delete-project-modal.tsx
#	web/components/project/join-project-modal.tsx
#	web/components/project/sidebar-list-item.tsx
#	web/components/project/sidebar-list.tsx
#	web/components/states/create-state-modal.tsx
#	web/components/states/create-update-state-inline.tsx
#	web/components/ui/datepicker.tsx
#	web/components/ui/multi-level-dropdown.tsx
#	web/components/views/delete-view-modal.tsx
#	web/components/workspace/confirm-workspace-member-remove.tsx
#	web/components/workspace/create-workspace-form.tsx
#	web/components/workspace/help-section.tsx
#	web/components/workspace/issues-list.tsx
#	web/components/workspace/send-workspace-invitation-modal.tsx
#	web/components/workspace/sidebar-dropdown.tsx
#	web/components/workspace/sidebar-menu.tsx
#	web/components/workspace/views/modal.tsx
#	web/helpers/date-time.helper.ts
#	web/helpers/issue.helper.ts
#	web/pages/404.tsx
#	web/pages/[workspaceSlug]/me/profile/activity.tsx
#	web/pages/[workspaceSlug]/projects/[projectId]/issues/[issueId].tsx
#	web/pages/[workspaceSlug]/projects/[projectId]/pages/[pageId].tsx
#	web/pages/accounts/sign-up.tsx
@aaryan610 aaryan610 deleted the fix/estimate_select branch November 7, 2023 10:04
sriramveeraghanta added a commit that referenced this pull request Nov 9, 2023
* fix: package version fixes and mentions build error fixes (#2665)

* fix: existing issues modal for cycle and module (#2664)

* fix: existing issues modal for cycle and module

* refactor: existing issues modal code

* fix: build errors

* dev: On Demand Code Build for any branch (#2668)

* wip

* wip

* testing

* wip

* wip

* wip

* wip

* image push fix

* wip

* wip

* dynamic branch name and tag

* workflow_dispatch modified

* job splitting

* file sharing

* wip

* checking

* wip

* wip

* wip

* wip

* build fixes

* code upload download fixes

* image name change

---------

Co-authored-by: sriram veeraghanta <[email protected]>

* Fix/mentions spaces fix (#2667)

* feat: add mentions store to the space project

* fix: added mentions highlights in read only comment cards

* feat: added mention highlights in richtexteditor in space app

* fix: render the estimate select if estimate is enabled for the project (#2663)

* style: updated layouts UI in the space app (#2671)

* style: updated layouts UI in space

* fix: build error

* chore: update avatar group logic (#2672)

* fix: In kanban issues can be shifted between the column in order_by (#2676)

* fix: slack integration workflow (#2675)

* fix: slack integration workflow

* dev: add slack client id as configuration

* fix: clean up

* fix: added env to turbo

---------

Co-authored-by: sriram veeraghanta <[email protected]>

* fix: bug fixes and ui improvement (#2674)

* chore: peekoverview edit permission updated

* chore: tab index added in create project modal

* chore: project card improvement

* style: avatar component improvement

* chore: create issue modal improvement

* style: global style sidebar border variable name fix

* style: update border across workspace and project settings. (#2669)

* style: update border across workspace and project settings.

* update border width

* style: update project description as per design. (#2682)

* fix: kanban card state name and drop down items text overflow (#2686)

* fix: slack project integration (#2684)

* fix: replacing jira importer image (#2685)

* fix: cycle and module bug fixes and improvement (#2691)

* fix: cycle and module card issue count fix

* fix: cycle and module list progress icon fix

* fix: module card progress fix

* style: cycle & module empty date label updated

* fix: build error

* chore: spreadsheet layout improvement (#2677)

* style: spreadsheet column width fix

* style: spreadsheet label column styling

* chore: spreadsheet layout issue properties improvement

* fix: build error

* chore: user profile issue improvement (#2679)

* fix: user profile filters z-index

* chore: user profile issue state group heading fix

* fix: build error

* chore: peek overview improvement and bug fixes (#2683)

* style: issue peek overview improvement

* style: peek overview improvement

* fix: subscribe issue from peek overview fix and validation added

* fix: build error

* fix: state icon (#2678)

* fix: environment config changes in the API are replicated in web and space app (#2699)

* fix: envconfig type changes

* chore: configuration variables  (#2692)

* chore: update avatar group logic (#2672)

* chore: configuration variables

---------

* fix: replacing slack client id with env config

---------

Co-authored-by: Nikhil <[email protected]>

* dev: modified the branch wise build (#2702)

* cherrypicked branch build code

* trigger on pull request

* branch filter

* checking branch filter

* checking push

* checking push again

* code cleanup before PR

* style: update font weight in project general setting section. (#2697)

* dev: Modified the branch-build action yaml (#2704)

* cherrypicked code

* removed PUSH event

* dev: worker count (#2573)

* dev: workers count

* dev: update the worker count variable to GUNICORN_WORKERS

* style: update user profile button alignment. (#2695)

* fix: add issues to cycles and modules (#2659)

* fix: able to add issue in cycle and module

* fix: issue activity message

* fix: issue draft delete functionality (#2696)

* add errors for duplicate labels (#2706)

Co-authored-by: rahulramesha <[email protected]>

* style: spinner component improvement (#2708)

* fix: quick add not working for labels & assignee (#2689)

* fix: quick add not working for labels & assignee

* fix: build error on spreadsheet view

* refactor: replace keyboard events with command palette store (#2688)

* fix: project select validation (#2723)

* Fix: Render bar chart axis labels in lighter color when dark theme applied (#2721)

* fix: project automation settings flickering (#2680)

* fix: cycle and module sidebar z-index

* fix: project automation settings flickering

* chore: remove active ids from the MobX stores if not present in the route (#2681)

* chore: remove active ids if not present in the route

* refactor: set active id logic

* style: ui consistency and improvement (#2725)

* style: create/update issue modal properties ui improvement

* style: create update issue modal improvement

* style: modal ui consistency

* fix: bug fixes and ui improvements (#2703)

* fix: gantt chart duration in decimal

* fix: Loading text instead Spinner in peek view

* fix: cycle more popover typo & icon overlapping

* fix: list layout properties alignment

* fix: project search empty state

* fix: calendar layout issue text overflow & redirection inconsistency

* style: urgent priority hover background color

* fix: Cycle issues kanban layout empty state missing

* style: custom snooze modal placeholder text color

* refactor: replaced unwanted anchor tag with div

* chore: removed empty state for cycle kanban layout

* fix: unwanted go back button in onboarding step 2 (#2714)

* fix: added empty project state when no project exists. (#2727)

* fix: added empty project state when no project exists

* fix: duplicate import

* fix: issue property height and peek view date picker border radius (#2726)

* fix: all issues values not changeable and assignee image not rendering (#2707)

* fix: all issues values are not changeable and assignee image not rendering

* chore: removed console log

* [fix]: Error Handling for Images and Table Fix for Form Submissions in Editor (#2710)

* cancellable uploads and image limits with better error handling

* fixed table row/column picker behaviour on modals

* Merge branch 'rerender-debounce-editor-fix' into editor-draggable-nodes

* fix: added mention suggestions and highlights in `create-issue-modal`

* removed uncessary files

* solved lint error of trailing spaces

* added plane/ui dependency for tooltips

---------

Co-authored-by: Henit Chobisa <[email protected]>

* style: kanban card label overflow (#2722)

* chore: kanban card lable drop down items overflow

* style: kaban card label text overflow, tool tip, hover cursor

* style: label overflow in list layout

* fix: project states fixes (#2731)

* fix: project states fixes

* fix: states fixes

* fix: formating all files

* fix: toast alert inconsistency (#2730)

* fix: Tooltip content on assignee hover in all layouts (#2724)

* fix: Tooltip content on assignee hover in all layouts

* chore: comments added

* feat: state list endpoint (#2717)

* feat: state list endpoint

* dev: update states endpoint

* dev: mark default state endpoint

* fix: workspace members store added and implemented across the app (#2732)

* fix: minor changes

* fix: workspace members store added and implemnted across the app

* fix: cystom analytics bar graph index alignment (#2737)

* fix: Add horizontal scroll bar to views (#2736)

* add errors for duplicate labels

* adding horizonatal scroll bar to views

---------

Co-authored-by: rahulramesha <[email protected]>

* style: sidebar UI improvements (#2735)

* updated font weight and color as per designs.
* removed background color from workspace with logo.
* updated dropdown design.

* fix: UI improvements. (#2734)

* style: update check icon colors to match our design.

* fix: automatically focus input box in pages `add label` modal.

* fix: spliting out the project members from project store and service (#2739)

* refactor: gantt sidebar (#2705)

* refactor: gantt sidebar

* fix: exception error

fix: file placement

* refactor: not passing sidebar block as props

* chore: configuration add tracker variables (#2709)

* chore: configuration add tracker variables

* dev: unsplash configuration

* fix: mention notification (#2670)

* fix: mention notification

* feat: updated mentions for comments in the notification background task

* feat: added subscription for issue_comment_mentions as well

* fix: removed the print statement

* fix: double notification popup for mentioned assignees

* fix: added issue subscriber

* fix: removed creator for subscribed

* fix: creator will not be subscribed to issue

* fix: double notification removed

---------

Co-authored-by: Henit Chobisa <[email protected]>

* fix: favourite cycle and modules displayed at top (#2719)

* feat: issues v2 endpoint (#2713)

* feat: issue v2 listing endpoint

* dev: issues v3 endpoint

* dev: add permission in the grouped endpoint

* dev: update grouped endpoint

* fix: fliter list item clear button alignment fix (#2741)

* fix: date select tooltip fix (#2740)

* refactor: cycles store (#2716)

* refactor: cycles store

* refactor: active cycle details

---------

Co-authored-by: Aaryan Khandelwal <[email protected]>
Co-authored-by: Manish Gupta <[email protected]>
Co-authored-by: Henit Chobisa <[email protected]>
Co-authored-by: guru_sainath <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Anmol Singh Bhatia <[email protected]>
Co-authored-by: Prateek Shourya <[email protected]>
Co-authored-by: Ramesh Kumar Chandra <[email protected]>
Co-authored-by: Bavisetti Narayan <[email protected]>
Co-authored-by: rahulramesha <[email protected]>
Co-authored-by: rahulramesha <[email protected]>
Co-authored-by: Dakshesh Jain <[email protected]>
Co-authored-by: Ankush Deshmukh <[email protected]>
Co-authored-by: Lakhan Baheti <[email protected]>
Co-authored-by: sabith-tu <[email protected]>
Co-authored-by: M. Palanikannan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants