Skip to content

Conversation

@pablohashescobar
Copy link
Member

refactor: backend code cleanup

@vercel
Copy link

vercel bot commented Jan 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
plane ⬜️ Ignored (Inspect) Jan 16, 2023 at 6:32PM (UTC)
plane-dev ⬜️ Ignored (Inspect) Jan 16, 2023 at 6:32PM (UTC)
plane-docs ⬜️ Ignored (Inspect) Jan 16, 2023 at 6:32PM (UTC)
plane-staging ⬜️ Ignored (Inspect) Jan 16, 2023 at 6:32PM (UTC)

workspace=view.workspace, member=request.user, role__in=[15, 20]
workspace__slug=view.workspace_slug,
member=request.user,
role__in=[15, 20],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do it directly. Access it as a constant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes everywhere.

workspace=view.workspace, member=request.user, role__in=[15, 20]
workspace__slug=view.workspace_slug,
member=request.user,
role__in=[15, 20],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add constants

@pablohashescobar pablohashescobar merged commit f12b7ef into develop Jan 16, 2023
@pablohashescobar pablohashescobar deleted the refactor/code_cleanup branch March 15, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants