Skip to content

Add configurable on/off switch for Braintrust integration #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

Add configurable on/off switch for Braintrust integration #54

merged 3 commits into from
Feb 26, 2025

Conversation

@sayakmaity
Copy link
Contributor

@sayakmaity sayakmaity commented Feb 26, 2025 •
edited
Loading

Summary

  • Replace negative logic (BRAINTRUST_ORCHESTRA_DISABLED) with positive logic (BRAINTRUST_ORCHESTRA_ENABLED)
  • Make Braintrust integration auto-enabled by default when API key exists
  • Update documentation to reflect the new behavior
  • Provide explicit environment variable (BRAINTRUST_ORCHESTRA_ENABLED) for easier configuration

Test plan

  • Verify that Braintrust automatically enables when API key is present
  • Verify that setting BRAINTRUST_ORCHESTRA_ENABLED=false disables Braintrust integration
  • Verify that explicit BRAINTRUST_ORCHESTRA_ENABLED=true enables integration
  • Verify that documentation is clear and accurate

🤖 Generated with Claude Code

sayakmaity and others added 3 commits February 26, 2025 08:26
@sayakmaity
initial commit
407277a
@sayakmaity
updates and docs
f8a3645
@sayakmaity @claude
Change Braintrust logging switch from negative to positive logic
0ecf73e 
- Rename from BRAINTRUST_ORCHESTRA_DISABLED to BRAINTRUST_ORCHESTRA_ENABLED
- Make it default to enabled when API key exists
- Update documentation to reflect new behavior

🤖 Generated with Claude Code
Co-Authored-By: Claude <[email protected]>
@sayakmaity sayakmaity changed the title Add Braintrust environment variable toggle Add configurable on/off switch for Braintrust integration Feb 26, 2025
@sayakmaity sayakmaity merged commit cae9bb7 into main Feb 26, 2025
@sayakmaity sayakmaity deleted the sayak/mfe-440-add-better-onoff-switch-to-orchestra-braintrust-logging branch February 26, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@philippe-page philippe-page philippe-page approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakmaity @philippe-page