Introduced delay after pressing modifier keys #57
Conversation
There was a problem hiding this comment.
As a humble bystander, I don't think you'd want to commit anything other than the cs files in this PR. The changes the *proj files would break the existing nuget pipelines, and the change to the sln would mess things up too.
I'm not really equipped to provide any feedback on the .cs file changes, 🤷, but seems like a well intentioned idea!
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
There was a problem hiding this comment.
From your PR text, it doesn't seem intentional that you meant to change the target framework and all these versions?
There was a problem hiding this comment.
Yes, you are right! The changing of the target framework shouldn't have been included into this PR. But I'm always using the latest version of .NET in my projects and I think, this project should also be upgraded (with support for net6.0, net7.0, net8.0). But of course, as you say, this would also need some adaptions to the nuget pipelines and it would be better to do this in a separate PR.
This was necessary for me to get it running when working remotely over Citrix and RDP, because the modifier keys are not applying if the latency of the remote connection is too high. The same happens when I manually type too fast.