Skip to content

Conversation

@juanfriss
Copy link
Contributor

@juanfriss juanfriss commented Mar 20, 2024

Description

GC-2560

Bumps version up after axios dependency was upgaded in #275

@juanfriss juanfriss requested a review from a team as a code owner March 20, 2024 23:20
@juanfriss juanfriss requested review from bamohan, shannamurry and siddharthpant92 and removed request for a team March 20, 2024 23:20
@guardrails
Copy link

guardrails bot commented Mar 20, 2024

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@QuentinLemCode
Copy link

Jest v29 drop the support for Node V12
https://jest-archive-august-2023.netlify.app/docs/29.0/upgrading-to-jest29

You should drop the Node V12 support for this version

"address autocomplete"
],
"version": "1.3.3",
"version": "1.3.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to bump the package version

@juanfriss juanfriss changed the title GC-00/bumps up version GC-2560/bumps up version Mar 21, 2024
@QuentinLemCode
Copy link

QuentinLemCode commented Mar 22, 2024

@juanfriss Jest don't manage the error well
You can run the following command to see what make your tests fails :
npx jest -c jest.integrationConfig.js --detectOpenHandles

It seems the requests are failing, causing axios to throw an error

@juanfriss
Copy link
Contributor Author

@QuentinLemCode yeah, there's a problem with the integration tests (which as you say, don't mock the API call).

All tests pass (Tests: 93 passed, 93 total), but there's something else that's breaking the coverage report and generating a failed result for the action:

Node.js v18.19.1
node:internal/child_process/serialization:159
    const string = JSONStringify(message) + '\n';
                   ^

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'socket' -> object with constructor 'Object'
    --- property '_httpMessage' closes the circle
    at stringify (<anonymous>)
    at writeChannelMessage (node:internal/child_process/serialization:159:20)
    at process.target._send (node:internal/child_process:845:17)
    at process.target.send (node:internal/child_process:745:19)
    at reportSuccess (/home/runner/work/lob-typescript-sdk/lob-typescript-sdk/node_modules/jest-worker/build/workers/processChild.js:82:11)

@juanfriss
Copy link
Contributor Author

@QuentinLemCode running with --detectOpenHandles does throw much better and useful errors. Will check what's going on now.

@juanfriss juanfriss merged commit f8a32ad into main Mar 22, 2024
@juanfriss
Copy link
Contributor Author

all tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants