Skip to content

Conversation

@devnexen
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jan 15, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: David CARLIER (devnexen)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/123116.diff

1 Files Affected:

  • (modified) compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp (+1)
diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
index e72b810dd8c3bd..c26643c6a2d630 100644
--- a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
@@ -545,6 +545,7 @@ TEST_F(RtsanOpenedFileTest, FtelloDieWhenRealtime) {
 
 TEST_F(RtsanOpenedFileTest, RewindDieWhenRealtime) {
   int end = fseek(GetOpenFile(), 0, SEEK_END);
+  EXPECT_THAT(end, Eq(0));
   auto Func = [this]() { rewind(GetOpenFile()); };
 
   ExpectRealtimeDeath(Func, "rewind");

@fmayer
Copy link
Contributor

fmayer commented Jan 15, 2025

Please say "fix unused variable warning" or something in commit message

@devnexen devnexen changed the title [compiler-rt][rtsan] Fix fseek text build. [compiler-rt][rtsan] Fix fseek test build (unused variable warning). Jan 15, 2025
@devnexen devnexen merged commit d15d410 into llvm:main Jan 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants