Skip to content

Fix issue where "CDATA" was incorrectly used as content type in atom entries #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue where "CDATA" was incorrectly used as content type in atom entries #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feedgen/entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def _add_text_elm(entry, data, name):
)
# Add type description of the content
if type_:
elm.attrib['type'] = type_
elm.attrib['type'] = 'html' if type_ == 'CDATA' else type_


class FeedEntry(object):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def test_content_cdata_type(self):
fe.title('some title')
fe.content('content', type='CDATA')
result = fg.atom_str()
assert b'<content type="CDATA"><![CDATA[content]]></content>' in result
assert b'<content type="html"><![CDATA[content]]></content>' in result

def test_summary_html_type(self):
fg = FeedGenerator()
Expand Down