Update build #5
Open
Update build #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous base image (Ubuntu 20.10) was a non-LTS release and is now unsupported so the Docker build command failed because it couldn't find the apt repos. Using golang base images simplifies the Dockerfile (since we no longer need to install golang ourselves) and since they're based on Debian Bullseye they'll be supported for a while.
The make target used to be hard-coded in the Docker entrypoint so you could only make the "all" target. Now the target is in the CMD so you can override it, e.g.: $ docker run --rm -v $(pwd)/:/app/:z hello clean The default behavior is the same as before, i.e., "make all".
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this project!
Here are a few small tweaks to get the Dockerfile ship-shape.