ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Ensure __bootc_validation is passed as a boolean in CI, upgrade tox-lsr to v3.11.1 across workflows, improve TF test failure detection, and document local CI testing with tox-lsr and QEMU.

CI:

• Update tox-lsr dependency from v3.11.0 to v3.11.1 in all GitHub Actions workflows
• Pass __bootc_validation as a YAML boolean in the QEMU integration tests (--extra-vars "__bootc_validation: true")
• Extend tft_citest_bad workflow to treat cancelled runs as failures alongside actual failures

Documentation:

• Add a new section to contributing.md with step-by-step instructions for running CI tests locally using tox-lsr and QEMU

[sourcery-ai]

Reviewer's Guide

This PR enhances CI configurations by passing the __bootc_validation flag as a YAML boolean instead of a string, bumps the tox-lsr dependency across multiple workflows, refines the TFT retry logic to include cancelled runs, and adds a local CI testing guide in contributing.md.

Flow diagram for passing __bootc_validation as boolean in CI

flowchart TD
  A["Start CI workflow"] --> B["Set extra-vars for __bootc_validation"]
  B --> C["Pass __bootc_validation: true (YAML boolean)"]
  C --> D["Run tests with correct boolean value"]
  D --> E["End workflow"]

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as a YAML boolean	Replaced -e __bootc_validation=true with -e "__bootc_validation: true"	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version in CI workflows	Updated pip install from 3.11.0 to 3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Include cancelled runs in TFT CI logic	Expanded jq filter to select both failure and cancelled conclusions Added comment noting TF tests may be cancelled	.github/workflows/tft_citest_bad.yml
Document local CI test setup	Added “Running CI Tests Locally” section with steps for using tox-lsr and qemu Outlined installation and configuration instructions	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• The new QEMU testing instructions in contributing.md are quite extensive—consider moving them to a dedicated guide or collapsing them behind a reference link to keep the main contributing guide concise.
• Step 2 refers to installing a script named "standard-test-roles-inventory-qemu" but the fallback download URL points to "standard-inventory-qcow2"—please reconcile these names for consistency.
• Since you’re bumping the tox-lsr version across multiple workflows, consider centralizing the version in one place (e.g. a reusable workflow or env variable) to simplify future updates.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The new QEMU testing instructions in contributing.md are quite extensive—consider moving them to a dedicated guide or collapsing them behind a reference link to keep the main contributing guide concise.
- Step 2 refers to installing a script named "standard-test-roles-inventory-qemu" but the fallback download URL points to "standard-inventory-qcow2"—please reconcile these names for consistency.
- Since you’re bumping the tox-lsr version across multiple workflows, consider centralizing the version in one place (e.g. a reusable workflow or env variable) to simplify future updates.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}